From patchwork Mon Aug 17 15:16:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 247831 Delivered-To: patch@linaro.org Received: by 2002:a92:cc90:0:0:0:0:0 with SMTP id x16csp2835023ilo; Mon, 17 Aug 2020 10:47:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzZi41sS8MPwM7HjsYpsfQwGDN1FIYGrywQXhywpbmDrYZjV381QUqUygjF4qkPoZPFvz93 X-Received: by 2002:a17:906:4ec3:: with SMTP id i3mr15974762ejv.215.1597686437373; Mon, 17 Aug 2020 10:47:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1597686437; cv=none; d=google.com; s=arc-20160816; b=ipcY7+ava2AnqsH9mu1OmKdycYBckhuVcLF1t4cUP01X7GecIC08ZYR78GOPE4yV2w NQ3683PKTgfjVnHHZ92B5lMp28xQyfJMev0PsSq0enqIUUolJnHoB36e2Ro5UoFprcsI SuoVk1Ooiy8rztrBj+wWS9SWQNJUi796yRIwujWZDGpkU9YF+ZHLLMalaQO6o/XaY/xU W7Eaml4Sslr3EPiWFI+FzgIOUuRVleqfAZ2AYljTd2LIRytl8/h1jUqV79IiFrpF++LB cRg1locaR5rnw4sZlwmwf8k+g0KTS0Dv8o+LSr7FJRj7NYg3aNunTG9MRAQjW9jg1lYn l2xw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=CsxtFe9OmY9q3oqoK+6JGGqYpQMg0iXZX3x/esM9488=; b=XTWndyXc/v31GtErVjQ+aa2gKFFQNGgsOH/MEqxXAOPsbkPEtJ0Taitd+JcYbdXb0n GdYkeDrB5B90lfIAhcZCsqK88Ka9wVgcdCizIARUvOnzNhRMNYecjmDT0Ar8jsQ3shOU bJmiO82gYJJjWZ8q5gBCTJD1qo69KB7d3LQzzJp2eOT6JS0X3bWV4GctDWhkHiVP96VW +PaGPR4rwpDSzqtzea6L4VX0xYoA+mQznzhx3QnSGPo1b5/T9JmXoby6TdOhPZaoiPVZ orivMlvCkFA6j1ktAPIczoOefcRBV5IAuRLx5qFHuiz4rUPR679uzjtIOH4vS5qRVwKx 3OXQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yl+RsByL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q12si11584048edh.55.2020.08.17.10.47.17; Mon, 17 Aug 2020 10:47:17 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=yl+RsByL; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=linuxfoundation.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729615AbgHQRrP (ORCPT + 15 others); Mon, 17 Aug 2020 13:47:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:48230 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388569AbgHQQNi (ORCPT ); Mon, 17 Aug 2020 12:13:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 9722922D00; Mon, 17 Aug 2020 16:13:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597680806; bh=deAXlMAOnKUuC4bREE4TaknAbxR6vkBJLpB4dFrHtk0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=yl+RsByLDEwqmCMRVgzAKgCwAR7GKUMpoybQ2yVHVlAmhLDgELvGErhRbo7Qte9TW MIWqcv2/oJrJivYB5FGFyKpRZPEebyBKp1/P/iQtl2hTShV0L3PBPHLcVOcjrUWi6w i8YYWz8DgCpFJMrYhbYrB2X2aMlj98OTnvTx5p1s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Arnd Bergmann , Pavel Machek , Sasha Levin Subject: [PATCH 4.19 063/168] leds: lm355x: avoid enum conversion warning Date: Mon, 17 Aug 2020 17:16:34 +0200 Message-Id: <20200817143736.889798804@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200817143733.692105228@linuxfoundation.org> References: <20200817143733.692105228@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Arnd Bergmann [ Upstream commit 985b1f596f9ed56f42b8c2280005f943e1434c06 ] clang points out that doing arithmetic between diffent enums is usually a mistake: drivers/leds/leds-lm355x.c:167:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion] reg_val = pdata->pin_tx2 | pdata->ntc_pin; ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ drivers/leds/leds-lm355x.c:178:28: warning: bitwise operation between different enumeration types ('enum lm355x_tx2' and 'enum lm355x_ntc') [-Wenum-enum-conversion] reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode; ~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~~~~ In this driver, it is intentional, so add a cast to hide the false-positive warning. It appears to be the only instance of this warning at the moment. Fixes: b98d13c72592 ("leds: Add new LED driver for lm355x chips") Signed-off-by: Arnd Bergmann Signed-off-by: Pavel Machek Signed-off-by: Sasha Levin --- drivers/leds/leds-lm355x.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) -- 2.25.1 diff --git a/drivers/leds/leds-lm355x.c b/drivers/leds/leds-lm355x.c index 6cb94f9a2f3f3..b9c60dd2b1327 100644 --- a/drivers/leds/leds-lm355x.c +++ b/drivers/leds/leds-lm355x.c @@ -168,18 +168,19 @@ static int lm355x_chip_init(struct lm355x_chip_data *chip) /* input and output pins configuration */ switch (chip->type) { case CHIP_LM3554: - reg_val = pdata->pin_tx2 | pdata->ntc_pin; + reg_val = (u32)pdata->pin_tx2 | (u32)pdata->ntc_pin; ret = regmap_update_bits(chip->regmap, 0xE0, 0x28, reg_val); if (ret < 0) goto out; - reg_val = pdata->pass_mode; + reg_val = (u32)pdata->pass_mode; ret = regmap_update_bits(chip->regmap, 0xA0, 0x04, reg_val); if (ret < 0) goto out; break; case CHIP_LM3556: - reg_val = pdata->pin_tx2 | pdata->ntc_pin | pdata->pass_mode; + reg_val = (u32)pdata->pin_tx2 | (u32)pdata->ntc_pin | + (u32)pdata->pass_mode; ret = regmap_update_bits(chip->regmap, 0x0A, 0xC4, reg_val); if (ret < 0) goto out;