From patchwork Mon Aug 10 15:21:27 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 266654 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 0061AC433E0 for ; Mon, 10 Aug 2020 15:32:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCB15207FF for ; Mon, 10 Aug 2020 15:32:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597073578; bh=PZcRqQCNsNEq1ZS0iX1apEtdikPbEajs+XFzXYEZ6VM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=UpbArU6lgBqaGwN5JPy2zP3QHRImnQdVdkwR3MWtdxxfiY3X7nWr3CgoehHaOe1ZY qjYn9A64YgYVSp0Df9t7mLbEqX/SeWFDgq668dEKzET1GSnKg5fnj3bRJS5Tp2TBia HXfPZdgiZYQKmZvbTwip+1sMKHOSFm9QRsiytcdo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728152AbgHJPaA (ORCPT ); Mon, 10 Aug 2020 11:30:00 -0400 Received: from mail.kernel.org ([198.145.29.99]:36608 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729033AbgHJP36 (ORCPT ); Mon, 10 Aug 2020 11:29:58 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6BF0622D02; Mon, 10 Aug 2020 15:29:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1597073397; bh=PZcRqQCNsNEq1ZS0iX1apEtdikPbEajs+XFzXYEZ6VM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=CJyY/hDz5ge29JKa5430OqgN+RSleU8wioh6yBfZeoPlSWDEDQe838mIoY0hgyjPd 6+uOG/ahZgH+A4Jn6gODWGjYAh1xwYMweemNf4ToUSzqNK3kIPQhv8EsNXxc0HjvKx kL5/sjdJe3nJ3uR7pX2DLRXFYzc/zcxjvjoT+SPI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hui Wang , Takashi Iwai Subject: [PATCH 4.19 05/48] Revert "ALSA: hda: call runtime_allow() for all hda controllers" Date: Mon, 10 Aug 2020 17:21:27 +0200 Message-Id: <20200810151804.483653043@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200810151804.199494191@linuxfoundation.org> References: <20200810151804.199494191@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Hui Wang commit 07c9983b567d0ef33aefc063299de95a987e12a8 upstream. This reverts commit 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers"). The reverted patch already introduced some regressions on some machines: - on gemini-lake machines, the error of "azx_get_response timeout" happens in the hda driver. - on the machines with alc662 codec, the audio jack detection doesn't work anymore. Fixes: 9a6418487b56 ("ALSA: hda: call runtime_allow() for all hda controllers") BugLink: https://bugzilla.kernel.org/show_bug.cgi?id=208511 Cc: Signed-off-by: Hui Wang Link: https://lore.kernel.org/r/20200803064638.6139-1-hui.wang@canonical.com Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/hda/hda_intel.c | 1 - 1 file changed, 1 deletion(-) --- a/sound/pci/hda/hda_intel.c +++ b/sound/pci/hda/hda_intel.c @@ -2478,7 +2478,6 @@ static int azx_probe_continue(struct azx if (azx_has_pm_runtime(chip)) { pm_runtime_use_autosuspend(&pci->dev); - pm_runtime_allow(&pci->dev); pm_runtime_put_autosuspend(&pci->dev); }