From patchwork Mon Aug 3 12:19:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 266822 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C7B68C433E0 for ; Mon, 3 Aug 2020 12:44:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9B61E2054F for ; Mon, 3 Aug 2020 12:44:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596458670; bh=ZebsgRlP8hn5P1mHLwhnSzCiMqdPoQ97ZpjFWDWGEwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=HGAL9NHqnNG7ToqEwFUPoxYNR0qB2dP1hnoSSFZbm+XE+6uNpnQ5xfQKzMILSlo/u BDFd4dvs7qgxWX/j08RGLn4TdTK/TXfbXsMO/NrBIC4lzntlRMO8YMr1l/V1Ry8xhR S5sUi414lcN3HbrOgkWfOxmqvr1Y46FowtkdERBU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728103AbgHCM2J (ORCPT ); Mon, 3 Aug 2020 08:28:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:54182 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728694AbgHCM2J (ORCPT ); Mon, 3 Aug 2020 08:28:09 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 84197207DF; Mon, 3 Aug 2020 12:28:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596457688; bh=ZebsgRlP8hn5P1mHLwhnSzCiMqdPoQ97ZpjFWDWGEwo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ZpBjlJmHWK+JMYLQp+lmHEmOY3TcbfUWs6k3q7mKXao7/nhqUNtnYJRXpq7Mzemcp q+POqLUm3veBqxy1UHmM7cCqosqppGRbJ81HKV6S9QHJCVWzrUr+MXZtoSN5Neen0Y r7wvsjOWDnmkXQ7KHg76NaxqLzLhZ3OzJYw6WhpM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sagi Grimberg , Christoph Hellwig , Sasha Levin Subject: [PATCH 5.4 39/90] nvme-tcp: fix possible hang waiting for icresp response Date: Mon, 3 Aug 2020 14:19:01 +0200 Message-Id: <20200803121859.509164023@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200803121857.546052424@linuxfoundation.org> References: <20200803121857.546052424@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sagi Grimberg [ Upstream commit adc99fd378398f4c58798a1c57889872967d56a6 ] If the controller died exactly when we are receiving icresp we hang because icresp may never return. Make sure to set a high finite limit. Fixes: 3f2304f8c6d6 ("nvme-tcp: add NVMe over TCP host driver") Signed-off-by: Sagi Grimberg Signed-off-by: Christoph Hellwig Signed-off-by: Sasha Levin --- drivers/nvme/host/tcp.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/nvme/host/tcp.c b/drivers/nvme/host/tcp.c index 7900814355c28..53e113a18a549 100644 --- a/drivers/nvme/host/tcp.c +++ b/drivers/nvme/host/tcp.c @@ -1319,6 +1319,9 @@ static int nvme_tcp_alloc_queue(struct nvme_ctrl *nctrl, } } + /* Set 10 seconds timeout for icresp recvmsg */ + queue->sock->sk->sk_rcvtimeo = 10 * HZ; + queue->sock->sk->sk_allocation = GFP_ATOMIC; if (!qid) n = 0;