From patchwork Mon Aug 3 12:19:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 266843 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC260C433DF for ; Mon, 3 Aug 2020 12:42:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9BEEC20678 for ; Mon, 3 Aug 2020 12:42:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596458535; bh=ntHVsyRurvGjVshNXwBX4PbkBBTnvkshNG9V5gbHCPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Ztz3zB674LpLbtgd+QMEeiMYKSCYNkBLfLsfEJACWgSVMCKLBkHHlUwjsShdmQ9qB wCnxDpt0BAlm9eFjMn4JUB+gGg3v09QeVCb18StjxwsTGcTaZwo/XLuLK3sMajqQgM 5jJ0Wap4NQ/NfNH1/gE6YrlpAQsg/243JCd3gzUI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729203AbgHCMmP (ORCPT ); Mon, 3 Aug 2020 08:42:15 -0400 Received: from mail.kernel.org ([198.145.29.99]:59352 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728716AbgHCMbl (ORCPT ); Mon, 3 Aug 2020 08:31:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 945B2207FC; Mon, 3 Aug 2020 12:31:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1596457900; bh=ntHVsyRurvGjVshNXwBX4PbkBBTnvkshNG9V5gbHCPw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l93+9UycmAS4Tj7vpqaPermwA0wdIYmgyCpZ/HiwzzR2keWt084ftnWQQVvlIIVum 6bKNiKkR/TJEFr6neRSVhvcd2ONeUJxLVY0lfAHy9exMtbQQFwKegZUfdcoo2VJr2K wf99In2NoxVbAr9JLOa1iVB0Ld+ai6jfFMLn5ArY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Navid Emamdoost , Alexandru Ardelean , Jonathan Cameron , Sasha Levin Subject: [PATCH 4.19 03/56] iio: imu: adis16400: fix memory leak Date: Mon, 3 Aug 2020 14:19:18 +0200 Message-Id: <20200803121850.469452687@linuxfoundation.org> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20200803121850.306734207@linuxfoundation.org> References: <20200803121850.306734207@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org [ Upstream commit 9c0530e898f384c5d279bfcebd8bb17af1105873 ] In adis_update_scan_mode_burst, if adis->buffer allocation fails release the adis->xfer. Signed-off-by: Navid Emamdoost Reviewed-by: Alexandru Ardelean Signed-off-by: Jonathan Cameron Signed-off-by: Sasha Levin --- drivers/iio/imu/adis16400_buffer.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/iio/imu/adis16400_buffer.c b/drivers/iio/imu/adis16400_buffer.c index e70a5339acb19..3fc11aec98b95 100644 --- a/drivers/iio/imu/adis16400_buffer.c +++ b/drivers/iio/imu/adis16400_buffer.c @@ -38,8 +38,11 @@ int adis16400_update_scan_mode(struct iio_dev *indio_dev, return -ENOMEM; adis->buffer = kzalloc(burst_length + sizeof(u16), GFP_KERNEL); - if (!adis->buffer) + if (!adis->buffer) { + kfree(adis->xfer); + adis->xfer = NULL; return -ENOMEM; + } tx = adis->buffer + burst_length; tx[0] = ADIS_READ_REG(ADIS16400_GLOB_CMD);