From patchwork Mon Jul 20 15:35:59 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 237287 Delivered-To: patch@linaro.org Received: by 2002:a92:d244:0:0:0:0:0 with SMTP id v4csp2094610ilg; Mon, 20 Jul 2020 08:46:17 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxUTbypmtSbJVbcf9KKqF+os1t5Sxqxvvzm4Ql6slMDZzkvN9tn7dgliB52KH0U8FdZ63xh X-Received: by 2002:a17:907:42d0:: with SMTP id nz24mr22202884ejb.135.1595259977593; Mon, 20 Jul 2020 08:46:17 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1595259977; cv=none; d=google.com; s=arc-20160816; b=TuMtUzqgSo392ZUnediU6t7fW/+Dr1bnnT/PCm1Fb0vnoE+xmOT5tQtRajk2JkMIsL fdQyhmCPL5mng0v97uIpu+cICmTxL+R/lRm91O7lIgElBbybBwufGtwfmD/hIYnjrtG/ +PRo0GGrLvmcwL2SOpjJVRnUATcRRYLpmx65D12Af/j/mgKP0AOmA9b0PR61jJVU+C73 pz9XxX/F8cW+rF16dezp5w5Of8stsC3KhTXYdLs2J3V59PmbuAkVtSRRv5rIOFpM9rLF LeFoWBBWAXaYkrwh6FcEYKaqZ9UTiT3D3Yvr9vU5UMFSz+QKrsjnZYl28fDrzTOQP5Vu oFPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Xc4YjGQpAl2xM7mLI+AwkXPXzcYNBtozffER+d70Zi8=; b=bz+KRLEDIteaSO8RMabPGi/swJDjTDTv6UtWol7+0ZJGra1cbxAyirHLmMYkXxxBAk przFzTpO3vaHtJrVJ6ylEFfLCFG2lHWT+pCimMpH5f2o/nsMOfjqpZ7GYM5DhiXbbjz6 w/lE43EOA7ihQPchCSBrT5qWBa6pK8wLQV2tqlkEUu1gkxoe7fDJuczDSnkgcSeMz+V/ WhkXUdC+ulpNlsR2HEZsSjjXiduc+58Pz6hoeHgzXm3ancChzuJbunESs8H0NUQH7Ob9 ItPtSItRkK+gtddQIIMbxsbWCTUh6UMDhQBoAwDxnPNLEGXKM8mXYr4DUS7M+9yNxtYU U7zQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BbPt6BRB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id q18si10805156edr.440.2020.07.20.08.46.17; Mon, 20 Jul 2020 08:46:17 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BbPt6BRB; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730638AbgGTPqQ (ORCPT + 15 others); Mon, 20 Jul 2020 11:46:16 -0400 Received: from mail.kernel.org ([198.145.29.99]:40888 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730004AbgGTPqP (ORCPT ); Mon, 20 Jul 2020 11:46:15 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 6D08822CB3; Mon, 20 Jul 2020 15:46:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1595259975; bh=JnzwTOSD0dOZ6oJQzFQMgryNk5uoLCeCyw24xgv3p0A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BbPt6BRB4YPuzCY02tClw/lyEqKGUJUyQBJDvxYB3TbrRTNt6Wl4FivsZw9Q2ZBUj FoyGvxkc3iuzF3nlmWFurZ4DqPp2DZsQ+iBUWeZg54Khg/sR6r12RfCb4/WzN9ympw UrkKXTdIZfXm3J27RkAZlJiHcVXeY33hPlc7jk7s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Charles Keepax , Vinod Koul , Takashi Iwai , Sasha Levin Subject: [PATCH 4.14 020/125] ALSA: compress: fix partial_drain completion state Date: Mon, 20 Jul 2020 17:35:59 +0200 Message-Id: <20200720152803.961487729@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200720152802.929969555@linuxfoundation.org> References: <20200720152802.929969555@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vinod Koul [ Upstream commit f79a732a8325dfbd570d87f1435019d7e5501c6d ] On partial_drain completion we should be in SNDRV_PCM_STATE_RUNNING state, so set that for partially draining streams in snd_compr_drain_notify() and use a flag for partially draining streams While at it, add locks for stream state change in snd_compr_drain_notify() as well. Fixes: f44f2a5417b2 ("ALSA: compress: fix drain calls blocking other compress functions (v6)") Reviewed-by: Srinivas Kandagatla Tested-by: Srinivas Kandagatla Reviewed-by: Charles Keepax Tested-by: Charles Keepax Signed-off-by: Vinod Koul Link: https://lore.kernel.org/r/20200629134737.105993-4-vkoul@kernel.org Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- include/sound/compress_driver.h | 10 +++++++++- sound/core/compress_offload.c | 4 ++++ 2 files changed, 13 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/include/sound/compress_driver.h b/include/sound/compress_driver.h index 33a07c3badf01..f58b8edf0371b 100644 --- a/include/sound/compress_driver.h +++ b/include/sound/compress_driver.h @@ -72,6 +72,7 @@ struct snd_compr_runtime { * @direction: stream direction, playback/recording * @metadata_set: metadata set flag, true when set * @next_track: has userspace signal next track transition, true when set + * @partial_drain: undergoing partial_drain for stream, true when set * @private_data: pointer to DSP private data */ struct snd_compr_stream { @@ -83,6 +84,7 @@ struct snd_compr_stream { enum snd_compr_direction direction; bool metadata_set; bool next_track; + bool partial_drain; void *private_data; }; @@ -186,7 +188,13 @@ static inline void snd_compr_drain_notify(struct snd_compr_stream *stream) if (snd_BUG_ON(!stream)) return; - stream->runtime->state = SNDRV_PCM_STATE_SETUP; + /* for partial_drain case we are back to running state on success */ + if (stream->partial_drain) { + stream->runtime->state = SNDRV_PCM_STATE_RUNNING; + stream->partial_drain = false; /* clear this flag as well */ + } else { + stream->runtime->state = SNDRV_PCM_STATE_SETUP; + } wake_up(&stream->runtime->sleep); } diff --git a/sound/core/compress_offload.c b/sound/core/compress_offload.c index 7ae8e24dc1e61..81624f6e3f330 100644 --- a/sound/core/compress_offload.c +++ b/sound/core/compress_offload.c @@ -723,6 +723,9 @@ static int snd_compr_stop(struct snd_compr_stream *stream) retval = stream->ops->trigger(stream, SNDRV_PCM_TRIGGER_STOP); if (!retval) { + /* clear flags and stop any drain wait */ + stream->partial_drain = false; + stream->metadata_set = false; snd_compr_drain_notify(stream); stream->runtime->total_bytes_available = 0; stream->runtime->total_bytes_transferred = 0; @@ -880,6 +883,7 @@ static int snd_compr_partial_drain(struct snd_compr_stream *stream) if (stream->next_track == false) return -EPERM; + stream->partial_drain = true; retval = stream->ops->trigger(stream, SND_COMPR_TRIGGER_PARTIAL_DRAIN); if (retval) { pr_debug("Partial drain returned failure\n");