From patchwork Wed Jun 24 14:57:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Lee Jones X-Patchwork-Id: 191682 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp674635ile; Wed, 24 Jun 2020 08:04:55 -0700 (PDT) X-Google-Smtp-Source: ABdhPJyVSeIJfOyoN39zazbjcKdhkmeWoLaKbBHez7tcQGQXgm8NsCA7cpASgknyvq/j3PmeuVgI X-Received: by 2002:aa7:d313:: with SMTP id p19mr20941843edq.32.1593011094892; Wed, 24 Jun 2020 08:04:54 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1593011094; cv=none; d=google.com; s=arc-20160816; b=vVispUhHx8vqeJiSXRdJqhWqyIWe8q8bICXiF6TV7r3Vn9eQb3ECNjlN94qLNjA1H6 9NTpGMgdTCa7IVZiIS23eKNKy21Hc/wi1sT027vhGv4v1b3ihlz2qU39RgKpr10R9TQq c8v6AHAdxAm0J2ycJgMiycKPTyRoSaqn8uhawFcB1duDfcC9014quBFifGNNCc+RsCGh UPXU6iuhLNggxogh86AIFC3zFHteFaEueYX01LVRUmwsypy/aMHPeCvfsrflFEd40krr ZyX9bFt/Hn9p0tQILZJY2VhkHly5hIBm8eIUkBgnRvyHehF6pULS/ltrAju5fMv73QSl Xz/g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:subject:cc:to:from :dkim-signature; bh=Ss7PoxbYLKDr3LBMlu1h9z6F9Bwyl8YcpPLuuDtA3OM=; b=U/JgmTNrYacqntXFsRk3NsAQTU0JIMXVguhGrwSmn+NpbJO1GhKFyJJ2Jkaqy8IAlm uwyf4S/uUqRCyRwHHj1Q5GLM5PgaHtfKyp2XpOeRPumhmRZDc0SWdHHhYy1FY4trG7yx MIaPoNXP7SxOEiHfNi1ZNaZkTm6mKK/GYjUNg4bd+4Z+RQQFbOKOehMzosQUKRtXy06m YuNHwsMrTrAutoBDy8+ahYOuecuAaSuOJlG8MOfkDAXFLsSyc5wj9KLGX4qswNwh8fj9 AS3h5f+YAdL54tPGIsQJPzWzQSM6m16w27Uweh9kWAXsrCGQKdj8bJfqQ+x0Zof+UdkI +8AQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zQRqE+UP; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id e19si14198281edr.418.2020.06.24.08.04.54; Wed, 24 Jun 2020 08:04:54 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@linaro.org header.s=google header.b=zQRqE+UP; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=linaro.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404369AbgFXPEx (ORCPT + 15 others); Wed, 24 Jun 2020 11:04:53 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2404338AbgFXPEv (ORCPT ); Wed, 24 Jun 2020 11:04:51 -0400 Received: from mail-wr1-x443.google.com (mail-wr1-x443.google.com [IPv6:2a00:1450:4864:20::443]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 18829C061573 for ; Wed, 24 Jun 2020 08:04:51 -0700 (PDT) Received: by mail-wr1-x443.google.com with SMTP id s10so2591434wrw.12 for ; Wed, 24 Jun 2020 08:04:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=Ss7PoxbYLKDr3LBMlu1h9z6F9Bwyl8YcpPLuuDtA3OM=; b=zQRqE+UPlzudn+/cNp26hST9pkqlAF/Roysjl/ZK7hSOKrbhU0+ps/0hPMPZsbtq/y 7wkqhhZfdcOFJBlLfaVIq6w0vtexOBLwbp/pjJGSxtLakMB6+zk27rhGv9J+ON8zZ6kn fzdXdcthiNFm1fkpxraeMNnxwh/t26zQo4S5e/5NFtzLHCzm4EadHFojnWIy7JuQe9cK 6ySZiZs6+kQpTsrLLTyxUW9nVNMXkbf3Ry1jJreYdNgKWyGYrXJxBMXhSJlWyVkmkG+7 0TNrihNQNOQlLEAzLWkhnniT+Ri1c30kv54Kd4HYaALy++kosXWN5+toAf8VcB8ifg3z Us4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=Ss7PoxbYLKDr3LBMlu1h9z6F9Bwyl8YcpPLuuDtA3OM=; b=c8Lx1NI4ydszwcKVeOBka2YLIP+qS/oSQ3+Ci1Xk0fRxY/GXGa4jZpaIA6b/Ddl5yk VBWk5KWIfU4xxvV+E1rMJME/3KXDlNU8+LCKjeL459JHV14HAy025QadqLW0/2iShEh/ j16JyUczcbh9tED0GQBV4nHBC7dz7JfXXWKJfxsFHYah/n/zK6AoTThffyiarJBOehD2 2l/8TYL0ZgDnIFGLaIIRn8NzKfpw2PEKPhSAHoQEmo3M417RAPI5ku4g0159YLjxY2MV TW4lfSgANLwOPL7cbaNptgCXtBS8EEgQ/fejUdJQply6KZ3Pc5p6H54zImUgEhXysVJY ht+w== X-Gm-Message-State: AOAM531M/ke680LaIhQr0JuNwmdTnIYY9XNiltKJAoTiaFjYMMoR3HCl joJYTEj1ypWwfzmCap1Xxv8s4g== X-Received: by 2002:a5d:6a07:: with SMTP id m7mr32024458wru.324.1593011089754; Wed, 24 Jun 2020 08:04:49 -0700 (PDT) Received: from localhost.localdomain ([2.27.35.144]) by smtp.gmail.com with ESMTPSA id f186sm8200319wmf.29.2020.06.24.08.04.48 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 24 Jun 2020 08:04:49 -0700 (PDT) From: Lee Jones To: daniel.thompson@linaro.org, jingoohan1@gmail.com, dri-devel@lists.freedesktop.org, linux-fbdev@vger.kernel.org Cc: linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Lee Jones , stable@vger.kernel.org, Bartlomiej Zolnierkiewicz , Daniel Jeong , LDD MLP Subject: [PATCH 7/8] backlight: lm3630a_bl: Remove invalid checks for unsigned int < 0 Date: Wed, 24 Jun 2020 15:57:20 +0100 Message-Id: <20200624145721.2590327-8-lee.jones@linaro.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200624145721.2590327-1-lee.jones@linaro.org> References: <20200624145721.2590327-1-lee.jones@linaro.org> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org unsigned ints 'sources' and 'bank' cannot be less than LM3630A_SINK_0 (0) and LM3630A_BANK_0 (0) respecitively, so change the logic to only check for thier two possible valid values. Fixes W=1 warnings: drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_led_sources’: drivers/video/backlight/lm3630a_bl.c:394:18: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 394 | if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1) | ^ drivers/video/backlight/lm3630a_bl.c: In function ‘lm3630a_parse_bank’: drivers/video/backlight/lm3630a_bl.c:415:11: warning: comparison of unsigned expression < 0 is always false [-Wtype-limits] 415 | if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1) | ^ Cc: Cc: Bartlomiej Zolnierkiewicz Cc: Daniel Jeong Cc: LDD MLP Signed-off-by: Lee Jones --- drivers/video/backlight/lm3630a_bl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) -- 2.25.1 Reviewed-by: Daniel Thompson diff --git a/drivers/video/backlight/lm3630a_bl.c b/drivers/video/backlight/lm3630a_bl.c index ee320883b7108..e88a2b0e59046 100644 --- a/drivers/video/backlight/lm3630a_bl.c +++ b/drivers/video/backlight/lm3630a_bl.c @@ -391,7 +391,7 @@ static int lm3630a_parse_led_sources(struct fwnode_handle *node, return ret; for (i = 0; i < num_sources; i++) { - if (sources[i] < LM3630A_SINK_0 || sources[i] > LM3630A_SINK_1) + if (sources[i] != LM3630A_SINK_0 && sources[i] != LM3630A_SINK_1) return -EINVAL; ret |= BIT(sources[i]); @@ -412,7 +412,7 @@ static int lm3630a_parse_bank(struct lm3630a_platform_data *pdata, if (ret) return ret; - if (bank < LM3630A_BANK_0 || bank > LM3630A_BANK_1) + if (bank != LM3630A_BANK_0 && bank != LM3630A_BANK_1) return -EINVAL; led_sources = lm3630a_parse_led_sources(node, BIT(bank));