From patchwork Tue Jun 23 19:53:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191547 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp2295923ile; Tue, 23 Jun 2020 13:10:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynsfeng5kL0njBPwfSRms6EwLQVFKjk7hKfTOQa7F7uyW0MiK+iulZnE4SoAlB89+P1hBd X-Received: by 2002:a17:906:547:: with SMTP id k7mr8277303eja.287.1592943056743; Tue, 23 Jun 2020 13:10:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592943056; cv=none; d=google.com; s=arc-20160816; b=vtBBby/g0Hmtg8QbPD/R1mD442oliBsobNZepHrzIVMqMyau3VzR7Z3M+ZCWzYRqyO k5atnk9F/lGqFrmihSQiKqUNR5fJdv4j4IYjYS5j+0y0RMA01SUbbpiq7+/pckAJou/g KMT/gnPC9gatJ/TyRwqDEfzGHOjd8rzxX01b1Tjob4CyJvbLoohUXuQAfjGVsGZV2Lip sHGl5FBxVIHqKtn70Cox8QBvLg/eX2UWNIqDMRdC1dSHcKjHsUKJt63S56xm/BW1RaSM ezKLsaqnD5nUeJ2odkfOmo8AOuq8nho6Pf169/IDxYg44K0nFB4JYaskDHEYwfpcU3BN 3SZQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=0FRGAVrgvchBE9+xI4sCbdShVYYpDd+8KiBVfT+VYd0=; b=EGM8QF8OPqJo6PXIal+oTWfwr/wnEMX4ESuXTS+a+8uiafMPh8hwciNWEf456Qz1+E 1df0ZRkV+2Fy1lyQztgR8IR/iF3K5vuT37uI/Qo33k/AnHNc3r5QEmDkPDP9K7fallS9 8O5nhkIRbk0OVPS19syyVsrdCAEpYrus7h/IFtY+LSd2EIpbm7W4J6bXAQUh0MitmTCq Q4juog6bUz1ygF2yG7dClNg8Tqz83aRfMraMKCNiIq6LSzl0y6PkSTwHszelMbKaOjjM 4kQoCJ4UICNOLEBHMLw0d86I2K5p7l+yvRr66L21IIFMdISM6RNSb1k0u09VM+A+eSDK rYrw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=svjegEs9; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dm9si14914435ejc.624.2020.06.23.13.10.56; Tue, 23 Jun 2020 13:10:56 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=svjegEs9; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388853AbgFWUKy (ORCPT + 15 others); Tue, 23 Jun 2020 16:10:54 -0400 Received: from mail.kernel.org ([198.145.29.99]:52168 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388850AbgFWUKx (ORCPT ); Tue, 23 Jun 2020 16:10:53 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E05EC20E65; Tue, 23 Jun 2020 20:10:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592943053; bh=U5b0UBf7FMEr2zEPspBFgp7gEax7PArlSSw6xZKwkrc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=svjegEs90Ldm74KvvflyBCax6pVlk8xP0lWNDH6UUzJBz7kRLrFGNp6uMPERRcGWB VF/phc5HGXikesP6xZVa42UQhNDyqSsr0xIwMYrhn7XqFJM+/NJ5ZB+QFF6x++GhdD yQT8/nQTVFNegYMbVVtSvUDMC5jhaU7nJCgESgVE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Tero Kristo , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 5.7 200/477] clk: ti: composite: fix memory leak Date: Tue, 23 Jun 2020 21:53:17 +0200 Message-Id: <20200623195417.039611647@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index 6a89936ba03af..eaa43575cfa5e 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -196,6 +196,7 @@ cleanup: if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); }