From patchwork Tue Jun 23 19:50:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191535 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp2290373ile; Tue, 23 Jun 2020 13:03:47 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzhZ61lWd/lHNSS2rlN4PrcZWG9m1dDxm8+HUlWPmvzOTIZqaVyossEwcefE81oQBAKJNgF X-Received: by 2002:a17:906:3905:: with SMTP id f5mr16064327eje.15.1592942627784; Tue, 23 Jun 2020 13:03:47 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592942627; cv=none; d=google.com; s=arc-20160816; b=q/GcA/OelKKqyoJ2xRvfiuZsJVoK+tNiYTbNjbPHrAa4qoULVXnwPljvLd2VHbkF0v CYRLP/BXfHaJ1OxAtkQ+8YUZnlFf+sA7uBpA2DPzqi6joQ5xInUgShGn3DWf2j8YmEHq ec+xMV7lqffqYNetTkb1y7KeuwmW0uKuBnKInM+i4UHFa+Fsxar4ifLZxB2Vrn4hNJtJ TvL0SzQfuQFAnokR63FL3IcHF/wDyEmhNF7ag4xQbKKM9LRtDSkiWsqD9qXpnu5Tz+yT 0+wIBSKA45/jrbIT6EgDonc5w+IsAdveS/lB12E/+VZeg1e0ksQy9Iu6S2siTbTMiIOX ++Sg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=lkqMHl8hOCzf/RRIJzsYnoR/IDbDzJNCdE0o+nowVKs=; b=bhivUdp0AGMp9MQC7B/MH2pXOX1FGTNlJaelYeIlC4Oaby+EpP8jJ47HzNOom/vWvt 9gYp8GvQ0FvFKjyNF2b8Q1Ie3GvnrvLZPeyO/nLiyfQjVwXeK3m1wP7RXJG0x2SV+2nM /XIcAannaH65Mbv2r46o+FavnYRDJwWAOmFLRGwOiSt1KSIq1CttpuweWi/h6fVToEHr I7uhfZiHPuwiNX52zmSwO4tI2oE3BLBcchf0y8GCwqV2I/pUi3FlVmi7i5dbgeCrz/6W EhqUEwsK23OnnZCXhrOEyQI4RvBfATr81MGw6lEBH1VP2TrHp5FsQjniHoHAviUrtgHx tqNw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HdviU5AJ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id o10si3217436edr.168.2020.06.23.13.03.47; Tue, 23 Jun 2020 13:03:47 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=HdviU5AJ; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388098AbgFWUDq (ORCPT + 15 others); Tue, 23 Jun 2020 16:03:46 -0400 Received: from mail.kernel.org ([198.145.29.99]:41626 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388096AbgFWUDp (ORCPT ); Tue, 23 Jun 2020 16:03:45 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 471762082F; Tue, 23 Jun 2020 20:03:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592942625; bh=CxE7DB/DxfV2qd4+TdcBAW9MuHejz0PAQ9Qz9EB1qrA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=HdviU5AJ0DJC43qvr+RHGwYxeWjukwNqU/j0eMsJp0ChOduDyau5PawrmS86l1Ptf +A/mb0UZpgGuM9frNTvEl29Jhben6v3SkI5VojFaUGhsGf6jW3V8wW/aptlsZeJiZt 6b6FhHdagmgLBDOH2ytDLb8CkrQDe4H1eptudgWQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Heikki Krogerus , Chunfeng Yun , Suzuki K Poulose , Alexandre Belloni , Wen Yang , chenqiwu , Bryan ODonoghue , Sasha Levin Subject: [PATCH 5.7 041/477] usb: roles: Switch on role-switch uevent reporting Date: Tue, 23 Jun 2020 21:50:38 +0200 Message-Id: <20200623195409.546274713@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195407.572062007@linuxfoundation.org> References: <20200623195407.572062007@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Bryan O'Donoghue [ Upstream commit 3e63cff384e625f09758ce8f4d01ae3033402b63 ] Right now we don't report to user-space a role switch when doing a usb_role_switch_set_role() despite having registered the uevent callbacks. This patch switches on the notifications allowing user-space to see role-switch change notifications and subsequently determine the current controller data-role. example: PFX=/devices/platform/soc/78d9000.usb/ci_hdrc.0 root@somebox# udevadm monitor -p KERNEL[49.894994] change $PFX/usb_role/ci_hdrc.0-role-switch (usb_role) ACTION=change DEVPATH=$PFX/usb_role/ci_hdrc.0-role-switch SUBSYSTEM=usb_role DEVTYPE=usb_role_switch USB_ROLE_SWITCH=ci_hdrc.0-role-switch SEQNUM=2432 Cc: Heikki Krogerus Cc: Greg Kroah-Hartman Cc: Chunfeng Yun Cc: Suzuki K Poulose Cc: Alexandre Belloni Cc: Wen Yang Cc: chenqiwu Cc: linux-kernel@vger.kernel.org Signed-off-by: Bryan O'Donoghue Link: https://lore.kernel.org/r/20200508162937.2566818-1-bryan.odonoghue@linaro.org Signed-off-by: Greg Kroah-Hartman Signed-off-by: Sasha Levin --- drivers/usb/roles/class.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/usb/roles/class.c b/drivers/usb/roles/class.c index 5b17709821dfd..27d92af296351 100644 --- a/drivers/usb/roles/class.c +++ b/drivers/usb/roles/class.c @@ -49,8 +49,10 @@ int usb_role_switch_set_role(struct usb_role_switch *sw, enum usb_role role) mutex_lock(&sw->lock); ret = sw->set(sw, role); - if (!ret) + if (!ret) { sw->role = role; + kobject_uevent(&sw->dev.kobj, KOBJ_CHANGE); + } mutex_unlock(&sw->lock);