From patchwork Tue Jun 23 19:55:54 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 191561 Delivered-To: patch@linaro.org Received: by 2002:a92:1f07:0:0:0:0:0 with SMTP id i7csp2309438ile; Tue, 23 Jun 2020 13:27:52 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkXjXkuodmEQFRjwCjCFRc2PUZT9+onBHW/fR94rVEhwOmKyxa0YBM75ta1iG4ratiJ5HI X-Received: by 2002:a17:906:7d1:: with SMTP id m17mr843766ejc.490.1592944072012; Tue, 23 Jun 2020 13:27:52 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592944072; cv=none; d=google.com; s=arc-20160816; b=bj+8N+meeY23K+zqA7jRRtwYuWULFeE/sArhK/nxh6Kk4V6AxToJ41vGZD4qn6G5PZ 0PvYRu6nPySFCjDtsmiVIZ4FTnohICW1UcZQs+XfR8yLZcu2u0Ik4itk001vyAzDasho C97HX/yNTqSfdSzVdOciYBaNt/kcMfqJ5Js7FIGa5AAd3Ylq7HDMrUCEJMXDsS0lCtIS O1SEQ5UZlrpoIz79mMqMxfqQeTbummEWoPMIVKsI539JjpnzkAa44thgkO+7Bm8p+Gvb z9xcJZph22pcFSBP8UVIksFP0WEvtBdfbDduPL3uSSR/y/B1HXwbg1ElXPfxUcVMQm2E yomQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hQ2OddAsVcJRz/i90cU65XMYWbJhSC2oy1btXnWgtVI=; b=QvFeDM8G9qNI9LSegLn3WMTTsB3QG0EDvWguy+y3H4lz3vpT8GUesjafi+psekhCOc bNM22xV2U7Jr/NGfo/Z78eqoE1i3xEOKPaLtmemZlrCRFX9RQW/xAv4ftssf5d/NCjzA dU2u2EgKh/hkGtnrPHkd6/cnG28CrSlzcHkx+Z6oso5I3XLEuacdFuycBcN/kpRJIJdm LXBinpxCr89T7tzo1iMUqy23sy8JXUQjOUlSCvco6TgKCfM/xNJQjVgIlCg023CkuFI0 pFkcz8Kv+W4hiLt7Kxl97YKvCdUCVnxoQQ9mpUCmmCa0r3pwd0E6Sx8pRvubY65d4I+D oJLg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jLB2Rm6p; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id a14si12241991edn.360.2020.06.23.13.27.51; Tue, 23 Jun 2020 13:27:52 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=jLB2Rm6p; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390788AbgFWU1u (ORCPT + 15 others); Tue, 23 Jun 2020 16:27:50 -0400 Received: from mail.kernel.org ([198.145.29.99]:47474 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390797AbgFWU1t (ORCPT ); Tue, 23 Jun 2020 16:27:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4BB79206EB; Tue, 23 Jun 2020 20:27:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944069; bh=fzeiN6tsY2DADDxWEE9Al9nLMAgTcZwQITGuYd9DniQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jLB2Rm6pYv2vqbiBV04bNluoM3pke1wFUq/c3G+w6Ws5zdHfUpfmIMNJ2BVmAQxXw kor8shVQTqHqqVzuB/WpPPEjiZIdgYnIACHQ0+VMMWG/reB6mpbJLjCQrbKVeN72H4 iwDfuhMpQJkTECT8RK7vPjK6YcUtkrVMUJ8xIhWw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 5.4 159/314] clk: samsung: exynos5433: Add IGNORE_UNUSED flag to sclk_i2s1 Date: Tue, 23 Jun 2020 21:55:54 +0200 Message-Id: <20200623195346.443015904@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195338.770401005@linuxfoundation.org> References: <20200623195338.770401005@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit 25bdae0f1c6609ceaf55fe6700654f0be2253d8e ] Mark the SCLK clock for Exynos5433 I2S1 device with IGNORE_UNUSED flag to match its behaviour with SCLK clock for AUD_I2S (I2S0) device until a proper fix for Exynos I2S driver is ready. This fixes the following synchronous abort issue revealed by the probe order change caused by the commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when adding all top level devices") Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 50 Comm: kworker/0:1 Not tainted 5.7.0-rc5+ #701 Hardware name: Samsung TM2E board (DT) Workqueue: events deferred_probe_work_func pstate: 60000005 (nZCv daif -PAN -UAO) pc : samsung_i2s_probe+0x768/0x8f0 lr : samsung_i2s_probe+0x688/0x8f0 ... Call trace: samsung_i2s_probe+0x768/0x8f0 platform_drv_probe+0x50/0xa8 really_probe+0x108/0x370 driver_probe_device+0x54/0xb8 __device_attach_driver+0x90/0xc0 bus_for_each_drv+0x70/0xc8 __device_attach+0xdc/0x140 device_initial_probe+0x10/0x18 bus_probe_device+0x94/0xa0 deferred_probe_work_func+0x70/0xa8 process_one_work+0x2a8/0x718 worker_thread+0x48/0x470 kthread+0x134/0x160 ret_from_fork+0x10/0x1c Code: 17ffffaf d503201f f94086c0 91003000 (88dffc00) ---[ end trace ccf721c9400ddbd6 ]--- Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos5433.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 4b1aa9382ad28..6f29ecd0442e1 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -1706,7 +1706,8 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", ENABLE_SCLK_PERIC, 7, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_I2S1, "sclk_i2s1", "sclk_i2s1_peric", - ENABLE_SCLK_PERIC, 6, CLK_SET_RATE_PARENT, 0), + ENABLE_SCLK_PERIC, 6, + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC, 5, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,