From patchwork Tue Jun 23 19:57:05 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191581 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1352538ecs; Tue, 23 Jun 2020 14:01:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwPVClGxBwJCYNAyHoHmMWd8HGlIM5hhLTMe/hGMD+YVDH6Y/YZG+xoTSUUDzktIR/xUio9 X-Received: by 2002:a17:906:2615:: with SMTP id h21mr21394678ejc.84.1592946076490; Tue, 23 Jun 2020 14:01:16 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592946076; cv=none; d=google.com; s=arc-20160816; b=DbiqaD6XMuK5TpNsvptJwyGX9R/NDKga5VECeMiKByuEeP5gCksWijozsaI8xO/OTe ugOBmv6ubmnfXEbkXOvWVtvHJJMTP9H70Gj4GknqL5szxvlLeIDU2D7zDih8ffbjuTvX xeLgh+UiES4AzyGX1uBgZkNe5jAJ1S2YV7SQm/+hikC3FWg9g7aSRU/8vrZwXU72Rsr2 K6EgbviuNv0YzgUGdQPneoWeaivq8PRqO433tGo9qXys/7+BBGuM2q5GXFn+kFeXTQik xNZ2yHOTKlcwBuy/WhqQy7F4dkSNNbG4nrj0wzdeWy6ZD6N8xC83MpEGnMPcKCJIX5ru DJLA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=hvMCBhbOU4cuCxjzmZHE9tz7RzgDCCmJ+zAdemu0DKs=; b=hmmMB1bquRRh8E8U2tRPmXTMo8zXjtakXOU+chuAHuJ8mKhWK2D82K7Ipx+fRJuZ0o Q9XOdF+uiprYNR9Z0HJIh1nYnr3TLo2hqf/bYpkfB3RIuTU07bhtqgpEFRAjo79tQ6ld /69TEGFzSxrGrrwynS+f8afXPSNqHiYNIFGrMql8EibD3UCPquGoUNq+XgVJVg3RsUOr bmEjpOwML6B+5C7II/J96sV1WrH0CQQcL0+ee+TZC1J7CGk+9S5UmBnm0Nai5CMMSqro QSLa5bqI2WqmcpIOcLzdXObLAQtJ2UFSt+4sjbhVMKTzisEfRgOSRaTJdYMTUkCSxKKw 38Sw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EEfJ86EU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ba1si12988278edb.349.2020.06.23.14.01.16; Tue, 23 Jun 2020 14:01:16 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=EEfJ86EU; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392184AbgFWUjz (ORCPT + 15 others); Tue, 23 Jun 2020 16:39:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:35708 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392177AbgFWUjy (ORCPT ); Tue, 23 Jun 2020 16:39:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C1921217D9; Tue, 23 Jun 2020 20:39:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944794; bh=SSj/Gu+vnua5vgrjvq55p0v4VVLdJec4meTq6j3WJ8M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EEfJ86EUY11InoTyYbZvLwLfMOE7NiTpM3XL3jVZk/d9lRloj/cw8m7m9QcMEpYov 2X9lQRUo7phbTG24aYxcT/DZmUvFGMU1uoI3ZINadH2jGwQ8sCLr/Lh9+WPut7OUnX ejb6wLKGxFe3gB9lawNr5/+KgEcJUDPC0cnMSmMA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Sylwester Nawrocki , Sasha Levin Subject: [PATCH 4.19 097/206] clk: samsung: exynos5433: Add IGNORE_UNUSED flag to sclk_i2s1 Date: Tue, 23 Jun 2020 21:57:05 +0200 Message-Id: <20200623195321.713036113@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski [ Upstream commit 25bdae0f1c6609ceaf55fe6700654f0be2253d8e ] Mark the SCLK clock for Exynos5433 I2S1 device with IGNORE_UNUSED flag to match its behaviour with SCLK clock for AUD_I2S (I2S0) device until a proper fix for Exynos I2S driver is ready. This fixes the following synchronous abort issue revealed by the probe order change caused by the commit 93d2e4322aa7 ("of: platform: Batch fwnode parsing when adding all top level devices") Internal error: synchronous external abort: 96000210 [#1] PREEMPT SMP Modules linked in: CPU: 0 PID: 50 Comm: kworker/0:1 Not tainted 5.7.0-rc5+ #701 Hardware name: Samsung TM2E board (DT) Workqueue: events deferred_probe_work_func pstate: 60000005 (nZCv daif -PAN -UAO) pc : samsung_i2s_probe+0x768/0x8f0 lr : samsung_i2s_probe+0x688/0x8f0 ... Call trace: samsung_i2s_probe+0x768/0x8f0 platform_drv_probe+0x50/0xa8 really_probe+0x108/0x370 driver_probe_device+0x54/0xb8 __device_attach_driver+0x90/0xc0 bus_for_each_drv+0x70/0xc8 __device_attach+0xdc/0x140 device_initial_probe+0x10/0x18 bus_probe_device+0x94/0xa0 deferred_probe_work_func+0x70/0xa8 process_one_work+0x2a8/0x718 worker_thread+0x48/0x470 kthread+0x134/0x160 ret_from_fork+0x10/0x1c Code: 17ffffaf d503201f f94086c0 91003000 (88dffc00) ---[ end trace ccf721c9400ddbd6 ]--- Signed-off-by: Marek Szyprowski Signed-off-by: Sylwester Nawrocki Signed-off-by: Sasha Levin --- drivers/clk/samsung/clk-exynos5433.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) -- 2.25.1 diff --git a/drivers/clk/samsung/clk-exynos5433.c b/drivers/clk/samsung/clk-exynos5433.c index 302596dc79a2c..0f2a9d767eefe 100644 --- a/drivers/clk/samsung/clk-exynos5433.c +++ b/drivers/clk/samsung/clk-exynos5433.c @@ -1680,7 +1680,8 @@ static const struct samsung_gate_clock peric_gate_clks[] __initconst = { GATE(CLK_SCLK_PCM1, "sclk_pcm1", "sclk_pcm1_peric", ENABLE_SCLK_PERIC, 7, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_I2S1, "sclk_i2s1", "sclk_i2s1_peric", - ENABLE_SCLK_PERIC, 6, CLK_SET_RATE_PARENT, 0), + ENABLE_SCLK_PERIC, 6, + CLK_SET_RATE_PARENT | CLK_IGNORE_UNUSED, 0), GATE(CLK_SCLK_SPI2, "sclk_spi2", "sclk_spi2_peric", ENABLE_SCLK_PERIC, 5, CLK_SET_RATE_PARENT, 0), GATE(CLK_SCLK_SPI1, "sclk_spi1", "sclk_spi1_peric", ENABLE_SCLK_PERIC,