From patchwork Tue Jun 23 19:56:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191582 Delivered-To: patch@linaro.org Received: by 2002:a54:3249:0:0:0:0:0 with SMTP id g9csp1354838ecs; Tue, 23 Jun 2020 14:04:34 -0700 (PDT) X-Google-Smtp-Source: ABdhPJzkCAwZtdhT8xuHhkZY/gSwx4QX6kkKZ3dxuMQHWpQ5X5cpnoZh2/fNP9oLdOqeWQsoD9JQ X-Received: by 2002:a17:906:6d15:: with SMTP id m21mr11922616ejr.209.1592946274643; Tue, 23 Jun 2020 14:04:34 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592946274; cv=none; d=google.com; s=arc-20160816; b=GmMwSGR3EXQBNDpWttWcE/dbEuQ9gk8W2kZBVibc0bpAABImyRJJhWX2wm4q925vJA P5zgt7UxT9eVwhIqX7Jn00dCgxz87ue0eJ1Kjp5SapeUdIq3bt2i5WfhWzaYMi6EGiNV DYBXvaN+kkr3/iZTeumjP43JCc/BGGBnt2PAgovwMrZWP8vCtOChm23owxlJua+wKB3s IWA1ETtVRwUxNpxvgXbStZ8CR5cy9Tw/TzxCsczp9QSukTrzZ5WHnrE9rhiDGz76q7qd Mdw5d/A4tLxZbKjnIXRDe0X6qBRU8gi/jsqYU3ZQTh+DcP6hkznILKlI1SXvyZcg29Q9 BlTQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=dMrypIkWzYjzauLbtVOKeLKEPOLJg4MziNoJApUH2uQ=; b=sNKIrF7r3GqgnG29AHUkkvS6p+DMhWw/GQn8Ho0wm1/YQK9+YSJaoNuv3rM6hxXBxZ Np+DHHSmcw5OKu2lYdNf4+/EOMuaGqWN4UeW8NR5322i2qaFWugUzynBlwdJzMSYqT/6 Rti5OUhOmqGWzvc8640ONouJCYeXpiWx2QCwrTujW7Mf+6yZmTNT89aBhnGJvLweqlRN 9N3AhJ/Ejbo31w/z+cwKieO4IbIhkmR1UNdO+cUSPEjUi4A3y1nabkRTAELiDex+QERa n6WUDcfR88L703oghqbLvlufgnzfz+2pIZ/qTlyrBrL9EXRutNQT13KXwuQ5FqyekSv8 DoXg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cRXx6goy; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id n15si11949302ejd.527.2020.06.23.14.04.34; Tue, 23 Jun 2020 14:04:34 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=cRXx6goy; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389669AbgFWVEc (ORCPT + 15 others); Tue, 23 Jun 2020 17:04:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:33258 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388289AbgFWUhz (ORCPT ); Tue, 23 Jun 2020 16:37:55 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41DC521582; Tue, 23 Jun 2020 20:37:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944675; bh=FH1Dcw5Wq2cpP9b9ZjB+7wg00CxQ4WqhkoJEEmdu6Zc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=cRXx6goyel29eOfqZY3GCWZqPmf5Txs83PdM32euiunS6DnAlIcv99ruDGggfWcuZ DQ+0ej4EQM3fz7yvmJJbxLh+mv4vWkr9hMu3g07SLwk7ktf4BxidPY7BOGzSItRZEm UG251P7xuwSdLYST299j+zPCT8Ww997TSr0AV8nI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Tomi Valkeinen , Tero Kristo , Tony Lindgren , Stephen Boyd , Sasha Levin Subject: [PATCH 4.19 081/206] clk: ti: composite: fix memory leak Date: Tue, 23 Jun 2020 21:56:49 +0200 Message-Id: <20200623195320.924648305@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Tero Kristo [ Upstream commit c7c1cbbc9217ebb5601b88d138d4a5358548de9d ] The parent_names is never released for a component clock definition, causing some memory leak. Fix by releasing it once it is no longer needed. Reported-by: Tomi Valkeinen Signed-off-by: Tero Kristo Link: https://lkml.kernel.org/r/20200429131341.4697-2-t-kristo@ti.com Acked-by: Tony Lindgren Signed-off-by: Stephen Boyd Signed-off-by: Sasha Levin --- drivers/clk/ti/composite.c | 1 + 1 file changed, 1 insertion(+) -- 2.25.1 diff --git a/drivers/clk/ti/composite.c b/drivers/clk/ti/composite.c index 030e8b2c10500..c6478d0b996b2 100644 --- a/drivers/clk/ti/composite.c +++ b/drivers/clk/ti/composite.c @@ -196,6 +196,7 @@ cleanup: if (!cclk->comp_clks[i]) continue; list_del(&cclk->comp_clks[i]->link); + kfree(cclk->comp_clks[i]->parent_names); kfree(cclk->comp_clks[i]); }