From patchwork Tue Jun 23 19:56:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 223297 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 72BD7C433DF for ; Tue, 23 Jun 2020 21:03:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5134520663 for ; Tue, 23 Jun 2020 21:03:41 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592946221; bh=TzNyeNTRndhnt9CP4fFLcc7wkIhGvqnA1cqAHrSXqlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=QT/5tmyB5wO4sPXVOCCXe5RXlXBTUtfANidM1OQJzpIK+1bjb/epQGZcgUWeN+vRv HUfMWBjxSKgThsfBQ8XE+gWhkiyZ/BGmG2avHIosmTLSiFctGTKbi8d5dNJf9LFtmT StdJ0DMuBOtquYF2qwoXAi8juswYwylkkMOYbSLs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389944AbgFWVDd (ORCPT ); Tue, 23 Jun 2020 17:03:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:34070 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2388912AbgFWUid (ORCPT ); Tue, 23 Jun 2020 16:38:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id CF8562085B; Tue, 23 Jun 2020 20:38:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592944714; bh=TzNyeNTRndhnt9CP4fFLcc7wkIhGvqnA1cqAHrSXqlY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MnnNHBgroCRcDPAwBQ0RCYtJ5rlxkUrkOH/mLLIhWmshB1pKPsFBxWQ3jEAyxTJ0v fzcR22VJD21Y5vDF36m8sTD07CuVYkHEqWXEHu5DOYX5giPjF+CuJ93pl8s2MkDn2Y D1JGzCQLsEuqDXlU7gDGnNtyHIYtruUny6cuAZoQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Pierre-Louis Bossart , Bard Liao , Ranjani Sridharan , Guennadi Liakhovetski , Vinod Koul , Sasha Levin Subject: [PATCH 4.19 066/206] soundwire: slave: dont init debugfs on device registration error Date: Tue, 23 Jun 2020 21:56:34 +0200 Message-Id: <20200623195320.204985936@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195316.864547658@linuxfoundation.org> References: <20200623195316.864547658@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Pierre-Louis Bossart [ Upstream commit 8893ab5e8ee5d7c12e0fc1dca4a309475064473d ] The error handling flow seems incorrect, there is no reason to try and add debugfs support if the device registration did not succeed. Return on error. Signed-off-by: Pierre-Louis Bossart Signed-off-by: Bard Liao Reviewed-by: Ranjani Sridharan Reviewed-by: Guennadi Liakhovetski Link: https://lore.kernel.org/r/20200419185117.4233-2-yung-chuan.liao@linux.intel.com Signed-off-by: Vinod Koul Signed-off-by: Sasha Levin --- drivers/soundwire/slave.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/soundwire/slave.c b/drivers/soundwire/slave.c index ac103bd0c1760..b6330b6672d59 100644 --- a/drivers/soundwire/slave.c +++ b/drivers/soundwire/slave.c @@ -55,6 +55,8 @@ static int sdw_slave_add(struct sdw_bus *bus, list_del(&slave->node); mutex_unlock(&bus->bus_lock); put_device(&slave->dev); + + return ret; } return ret;