From patchwork Tue Jun 23 19:59:38 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 223365 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.0 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE63AC433E0 for ; Tue, 23 Jun 2020 20:50:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id B02D420702 for ; Tue, 23 Jun 2020 20:50:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945458; bh=sF7PcTMMH1d2H0pPutO5VZxqofV3Hyn8GCLsRR8cK18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=jS6gJxESo81hRMcitWEPsqWPvxKYbn4nQLIhyrW2vh+4KiAEGz35MSGuu+gR6K+qX wYcJw1nrfoHCfzO8OcbaEVm4gfn92htbnvQqcqqF5Dz6JNxhNUJ6csGVFIL6MlNQKZ VVdGCXa0m5FP+I8OWk80WOrrPDT3rwa5LoXMScR0= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2390495AbgFWUu5 (ORCPT ); Tue, 23 Jun 2020 16:50:57 -0400 Received: from mail.kernel.org ([198.145.29.99]:47654 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2390269AbgFWUsd (ORCPT ); Tue, 23 Jun 2020 16:48:33 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5B4E621582; Tue, 23 Jun 2020 20:48:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592945313; bh=sF7PcTMMH1d2H0pPutO5VZxqofV3Hyn8GCLsRR8cK18=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=ja+3G3WIzVQhoH0+MUYaOlW+Epn6l2uz2f5lMnzFkY97zytG0iMUrA5NUk7uW+e1D NSwQR5vZf7X9HBcJsOypD/uy0CDLHxdgVW0BxuygNUouUrLMmbT3sB6xAH40Pq3/Ka /EjUTwgxR0/gzlcpzjEybNlfE+0LNUBSAwCBP9gI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Miquel Raynal , Sasha Levin Subject: [PATCH 4.14 122/136] mtd: rawnand: xway: Fix the probe error path Date: Tue, 23 Jun 2020 21:59:38 +0200 Message-Id: <20200623195309.881567612@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200623195303.601828702@linuxfoundation.org> References: <20200623195303.601828702@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Miquel Raynal [ Upstream commit 34531be5e804a8e1abf314a6c3a19fe342e4a154 ] nand_release() is supposed be called after MTD device registration. Here, only nand_scan() happened, so use nand_cleanup() instead. There is no real Fixes tag applying here as the use of nand_release() in this driver predates the introduction of nand_cleanup() in commit d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") which makes this change possible. However, pointing this commit as the culprit for backporting purposes makes sense even if this commit is not introducing any bug. Fixes: d44154f969a4 ("mtd: nand: Provide nand_cleanup() function to free NAND related resources") Signed-off-by: Miquel Raynal Cc: stable@vger.kernel.org Link: https://lore.kernel.org/linux-mtd/20200519130035.1883-61-miquel.raynal@bootlin.com Signed-off-by: Sasha Levin --- drivers/mtd/nand/xway_nand.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/mtd/nand/xway_nand.c b/drivers/mtd/nand/xway_nand.c index 1988bb943d1bc..176a94fa31d7f 100644 --- a/drivers/mtd/nand/xway_nand.c +++ b/drivers/mtd/nand/xway_nand.c @@ -211,7 +211,7 @@ static int xway_nand_probe(struct platform_device *pdev) err = mtd_device_register(mtd, NULL, 0); if (err) - nand_release(&data->chip); + nand_cleanup(&data->chip); return err; }