From patchwork Mon Jun 22 13:16:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Mikhail Kshevetskiy X-Patchwork-Id: 223611 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.2 required=3.0 tests=DKIM_ADSP_DISCARD, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A4D95C433DF for ; Mon, 22 Jun 2020 13:23:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 794B620702 for ; Mon, 22 Jun 2020 13:23:41 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728085AbgFVNXl (ORCPT ); Mon, 22 Jun 2020 09:23:41 -0400 Received: from shelob.oktetlabs.ru ([91.220.146.113]:48213 "EHLO shelob.oktetlabs.ru" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728048AbgFVNXl (ORCPT ); Mon, 22 Jun 2020 09:23:41 -0400 Received: by shelob.oktetlabs.ru (Postfix, from userid 122) id 167F17F5EA; Mon, 22 Jun 2020 16:16:50 +0300 (MSK) Received: from varda.oktetlabs.ru (varda.oktetlabs.ru [192.168.37.38]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPS id 080567F5E9; Mon, 22 Jun 2020 16:16:35 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 080567F5E9 Authentication-Results: shelob.oktetlabs.ru/080567F5E9; dkim=none; dkim-atps=neutral Received: from mkshevetskiy by varda.oktetlabs.ru with local (Exim 4.94) (envelope-from ) id 1jnMJO-008wpR-K4; Mon, 22 Jun 2020 16:16:34 +0300 From: Mikhail Kshevetskiy To: u-boot@lists.denx.de Cc: scottwood@freescale.com, Frieder Schrempf , stable@vger.kernel.org, Boris Brezillon Subject: [PATCH 3/4] mtd: spinand: Do not erase the block before writing a bad block marker Date: Mon, 22 Jun 2020 16:16:33 +0300 Message-Id: <20200622131634.2132717-3-mikhail.kshevetskiy@oktetlabs.ru> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200622131634.2132717-1-mikhail.kshevetskiy@oktetlabs.ru> References: <20200622131634.2132717-1-mikhail.kshevetskiy@oktetlabs.ru> MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Frieder Schrempf Currently when marking a block, we use spinand_erase_op() to erase the block before writing the marker to the OOB area. Doing so without waiting for the operation to finish can lead to the marking failing silently and no bad block marker being written to the flash. In fact we don't need to do an erase at all before writing the BBM. The ECC is disabled for raw accesses to the OOB data and we don't need to work around any issues with chips reporting ECC errors as it is known to be the case for raw NAND. Fixes: 7529df465248 ("mtd: nand: Add core infrastructure to support SPI NANDs") Cc: stable@vger.kernel.org Signed-off-by: Frieder Schrempf Reviewed-by: Boris Brezillon Signed-off-by: Miquel Raynal Link: https://lore.kernel.org/linux-mtd/20200218100432.32433-4-frieder.schrempf@kontron.de --- drivers/mtd/nand/spi/core.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/mtd/nand/spi/core.c b/drivers/mtd/nand/spi/core.c index c74a7b5ef3..e0ebd9c04b 100644 --- a/drivers/mtd/nand/spi/core.c +++ b/drivers/mtd/nand/spi/core.c @@ -712,19 +712,10 @@ static int spinand_markbad(struct nand_device *nand, const struct nand_pos *pos) }; int ret; - /* Erase block before marking it bad. */ ret = spinand_select_target(spinand, pos->target); if (ret) return ret; - ret = spinand_write_enable_op(spinand); - if (ret) - return ret; - - ret = spinand_erase_op(spinand, pos); - if (ret) - return ret; - return spinand_write_page(spinand, &req); }