From patchwork Fri Jun 19 14:33:58 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 191219 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp620152ilo; Fri, 19 Jun 2020 08:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJynuUdgfQCaw0jYFkgyoCnU6gsQyM09Wx3Rpp4AY/XxgrE4m08oji9TmReDoMDZV4dM+jA0 X-Received: by 2002:aa7:d5c7:: with SMTP id d7mr3908065eds.11.1592579771128; Fri, 19 Jun 2020 08:16:11 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592579771; cv=none; d=google.com; s=arc-20160816; b=JRSmDK0/y2Peya3CUARvZ4vlZRUHpF5mAQgpPGw6uROpp/uPklDSPMy69ztZdJqDdB OMWi8P91zRwAZ21HRVwHIDwqcMC72W2cZuTFbdQdWeL4AYRtQPeoAfBNnH/d8ZmAKfVw H3qhaaAaOxDDuX3/hMM2scsv1ls1iVWTAxV5BT8shHMf+SjyOkWcFDD7JAQCe9ajBnDR s7VBXvLuw67RMiruYs6/XDjSXopmqJ26twcqcv/bUbQIvDGjEvOKJZ/AHOgoWOYrUfjm Lt5SbHD2O2zsbs40Y4vuMaNHwD7QEabwr0KYJrR+tZxhcjT/879ekO8biuHU0ELd30rF AB6w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=Gu8R6OVg0FO1qlU9xEUHbl46Jrz1mG5kUq5tD61gwDg=; b=zP9kwjwhEio5QoNxZ31tDb2Smed8n5YEDqwSBdGQsgYdzAZ9A2E/cdrR/l9lCDjd0T sH62Z0zgR4xl9XLWcRnc0kFFdZLvTP5nN7AB5JgfBSJPLk8S1SZ0DYep5GAqaoBaKQpB ++Rirq81A/onjpoqRUMA6nS+4npyl07pnofvVbulNVm55RhPT3e6ORfATwDCzztsP4gg nKVyYSPdCtfM16+XaeTkB8TTmmJuv8IZqlZGk9UolYeexzfubt7915n4/x1/TtmZUE7f JVe8YR9Z4dRD5hsnUuKkgfBqhvQ2S5r53DyBb2fEpTOxdgKXCX24R4w0SfWdoYfyAnFX tNVw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BDd9UBnu; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id be6si3879584edb.405.2020.06.19.08.16.10; Fri, 19 Jun 2020 08:16:11 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=BDd9UBnu; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392462AbgFSPQH (ORCPT + 15 others); Fri, 19 Jun 2020 11:16:07 -0400 Received: from mail.kernel.org ([198.145.29.99]:46610 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392456AbgFSPQF (ORCPT ); Fri, 19 Jun 2020 11:16:05 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 59C422080C; Fri, 19 Jun 2020 15:16:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579764; bh=efE9qh+gRAoqSgGMofKgX7fsB1wxtB4Sw4lVk2loedU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=BDd9UBnui2EIV3Ni9Y/0wdvg8YKWK3frcc7DTokGjm4T3EhM+KXQ+Zbu4KB24pGXs E6fxBszNaBDSyqJBjwGX3pofklpQMKtN869mhVcKuPc9V4r7vogTz97B/J7p8Rbk6u pUKMT8aLZhOu117KZv4i1PQtIXWCgN+ErgC3uRoY= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Marek Szyprowski , Krzysztof Kozlowski Subject: [PATCH 5.4 227/261] ARM: dts: exynos: Fix GPIO polarity for thr GalaxyS3 CM36651 sensors bus Date: Fri, 19 Jun 2020 16:33:58 +0200 Message-Id: <20200619141700.738834102@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141649.878808811@linuxfoundation.org> References: <20200619141649.878808811@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Marek Szyprowski commit 8807d356bfea92b0a8f04ce421800ed83400cd22 upstream. GPIO lines for the CM36651 sensor I2C bus use the normal not the inverted polarity. This bug has been there since adding the CM36651 sensor by commit 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2"), but went unnoticed because the "i2c-gpio" driver ignored the GPIO polarity specified in the device-tree. The recent conversion of "i2c-gpio" driver to the new, descriptor based GPIO API, automatically made it the DT-specified polarity aware, what broke the CM36651 sensor operation. Fixes: 85cb4e0bd229 ("ARM: dts: add cm36651 light/proximity sensor node for exynos4412-trats2") CC: stable@vger.kernel.org # 4.16+ Signed-off-by: Marek Szyprowski Signed-off-by: Krzysztof Kozlowski Signed-off-by: Greg Kroah-Hartman --- arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi +++ b/arch/arm/boot/dts/exynos4412-galaxy-s3.dtsi @@ -68,7 +68,7 @@ i2c_cm36651: i2c-gpio-2 { compatible = "i2c-gpio"; - gpios = <&gpf0 0 GPIO_ACTIVE_LOW>, <&gpf0 1 GPIO_ACTIVE_LOW>; + gpios = <&gpf0 0 GPIO_ACTIVE_HIGH>, <&gpf0 1 GPIO_ACTIVE_HIGH>; i2c-gpio,delay-us = <2>; #address-cells = <1>; #size-cells = <0>;