From patchwork Fri Jun 19 14:33:47 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224118 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2A05CC433E1 for ; Fri, 19 Jun 2020 15:14:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id F1FC62158C for ; Fri, 19 Jun 2020 15:14:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579663; bh=QN44B5NjpaGuNWBUkEo8AlBVX8FksItPDzsjMKTnT0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=K/0Ic0MAHuuO1zr/2xRFSK474O4oAghJh3H71pC0fKwQp9J70T1kpu9VTCYiW+u/v jcMTmfguzIPb9E0mOZwtXuRkrfF19/J4lTs8dvJWb97QOZOX7MZp9jFGKa81zCcM5u tCuW1Ztp/rs70iC8F2PmLVPZ0UtCIGXOUprWaWaQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392313AbgFSPOU (ORCPT ); Fri, 19 Jun 2020 11:14:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:44858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392072AbgFSPOS (ORCPT ); Fri, 19 Jun 2020 11:14:18 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3080B206FA; Fri, 19 Jun 2020 15:14:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592579657; bh=QN44B5NjpaGuNWBUkEo8AlBVX8FksItPDzsjMKTnT0k=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jYjs8dFxUrFP2SvXkMNrIVMgjzsfsMlJ5+/A8RYg+QzgIgulsBNiD61oN8fyleWkF PpZPGs9QZ+WVU8gRsHbTHfZj4iB5q8N8CRm5E56lBFxltALFNJemA9rN+HbxCnFc7v IGs5uMUC0STZo0pcnvifYz9blWP+1dN10tpWnHzs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Wei Yongjun , Johan Hovold Subject: [PATCH 5.4 216/261] gnss: sirf: fix error return code in sirf_probe() Date: Fri, 19 Jun 2020 16:33:47 +0200 Message-Id: <20200619141700.231720190@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200619141649.878808811@linuxfoundation.org> References: <20200619141649.878808811@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Wei Yongjun commit 43d7ce70ae43dd8523754b17f567417e0e75dbce upstream. Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. This avoids a use-after-free in case the driver is later unbound. Fixes: d2efbbd18b1e ("gnss: add driver for sirfstar-based receivers") Reported-by: Hulk Robot Signed-off-by: Wei Yongjun [ johan: amend commit message; mention potential use-after-free ] Cc: stable # 4.19 Signed-off-by: Johan Hovold Signed-off-by: Greg Kroah-Hartman --- drivers/gnss/sirf.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) --- a/drivers/gnss/sirf.c +++ b/drivers/gnss/sirf.c @@ -439,14 +439,18 @@ static int sirf_probe(struct serdev_devi data->on_off = devm_gpiod_get_optional(dev, "sirf,onoff", GPIOD_OUT_LOW); - if (IS_ERR(data->on_off)) + if (IS_ERR(data->on_off)) { + ret = PTR_ERR(data->on_off); goto err_put_device; + } if (data->on_off) { data->wakeup = devm_gpiod_get_optional(dev, "sirf,wakeup", GPIOD_IN); - if (IS_ERR(data->wakeup)) + if (IS_ERR(data->wakeup)) { + ret = PTR_ERR(data->wakeup); goto err_put_device; + } ret = regulator_enable(data->vcc); if (ret)