From patchwork Tue Jun 16 15:35:11 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 188076 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp3791747ilo; Tue, 16 Jun 2020 09:15:58 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9aomBv9707qQSNgxJQt+l61sHcO+uhu3nLta5csIvPG1pn7QWGjnn9I+QIBdyPdLW3QHo X-Received: by 2002:a50:ab16:: with SMTP id s22mr3320810edc.345.1592324158438; Tue, 16 Jun 2020 09:15:58 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1592324158; cv=none; d=google.com; s=arc-20160816; b=RfSSn4Jexe0hFyfkUfQINmOuBt0oM9UrsGl1fHVqHhp1pcvynOO7VeyZuDQl7aVmQV XyXb7AtkS1+NL/EvHMe3oZv+ABhEvSm/oK8KKY2ehHlSrdNRb7zAhOUym0rHfPHWS8lc jDUZ7+Jl3MQgVqEu0uAhElkY6LFoaTi4yFgXAQGL3H+TzQm/NedqoiD7+IBFg8FDbcyy aGkqd38PqS2k0pYb6ShuhnxJ2oKZLNgtwJQdKzIKB7i/QPaRV9ta0ov8U6nXYs9r8gs8 27AP+tBmMwRFzPgcoQflR++BEmHXHuzIstGEeFLoAbig+odOJ5bg47IkPz5AoMKfA4Vy bY2Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=YkWwwqU61Cd3tWGUozAUqsNvfC2yXBmK+hMGlqjbL+E=; b=Pb4uILicN4RmHHh2vQ76UErsociPMH2jU7qFqQdmL22JcA1gICkzfByWvTRVQlKWRi L+/lrgrm6SgSz+MGGXWRhb2nY50h157ngGMYdq2wtiPnknlwK+INLlLw316AHKQ+FvPF zuyTMxCpwG5DKE/wCujscpsUYQr9/qbqNZ4FnXJTt8Fi0pxjUpGj/iZHph2VHyevgv1i XjnOYfI+40RSMLsA8FXOI5ScjEf400jx6PoaU2sOvnKqbMcVRP0nMrh+O0YXzV6c8juS rUEfplXccrDwAaJhfSI6rNJDAZdTFmuf7nLvmNx5A7P3rWtYd7yyxU/PtU2K+9PgATaH 2Apg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lMV/Xrxd"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id dn1si14690955ejc.638.2020.06.16.09.15.58; Tue, 16 Jun 2020 09:15:58 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b="lMV/Xrxd"; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731321AbgFPQPt (ORCPT + 15 others); Tue, 16 Jun 2020 12:15:49 -0400 Received: from mail.kernel.org ([198.145.29.99]:56866 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730630AbgFPPlV (ORCPT ); Tue, 16 Jun 2020 11:41:21 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1BEC5207C4; Tue, 16 Jun 2020 15:41:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592322079; bh=WhB8wqDXsccYzqQ2R4iFnNEDS50yOon3Np6rrhti2b8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lMV/XrxdJ+A2K4w9F+8qC2kV6gMnhSQ5bDBvly+RFiHiY47Kd9qBmuMx63FHIHsU3 /QD5mqQ4OO8DqH2jaJ/OOMNuxarPSXIIpabd+ZZpe2fmjLEMPvg+h2TpWD27eeAoi0 KDviqZ9AlytdBRaDsoC+ASkge+/Z8MpP56AfjkD4= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Masahiro Yamada , Ulf Hansson Subject: [PATCH 5.4 127/134] mmc: uniphier-sd: call devm_request_irq() after tmio_mmc_host_probe() Date: Tue, 16 Jun 2020 17:35:11 +0200 Message-Id: <20200616153106.869210030@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153100.633279950@linuxfoundation.org> References: <20200616153100.633279950@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Masahiro Yamada commit 5d1f42e14b135773c0cc1d82e904c5b223783a9d upstream. Currently, tmio_mmc_irq() handler is registered before the host is fully initialized by tmio_mmc_host_probe(). I did not previously notice this problem. The boot ROM of a new Socionext SoC unmasks interrupts (CTL_IRQ_MASK) somehow. The handler is invoked before tmio_mmc_host_probe(), then emits noisy call trace. Move devm_request_irq() below tmio_mmc_host_probe(). Fixes: 3fd784f745dd ("mmc: uniphier-sd: add UniPhier SD/eMMC controller driver") Signed-off-by: Masahiro Yamada Cc: stable@vger.kernel.org Link: https://lore.kernel.org/r/20200511062158.1790924-1-yamada.masahiro@socionext.com Signed-off-by: Ulf Hansson Signed-off-by: Greg Kroah-Hartman --- drivers/mmc/host/uniphier-sd.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) --- a/drivers/mmc/host/uniphier-sd.c +++ b/drivers/mmc/host/uniphier-sd.c @@ -614,11 +614,6 @@ static int uniphier_sd_probe(struct plat } } - ret = devm_request_irq(dev, irq, tmio_mmc_irq, IRQF_SHARED, - dev_name(dev), host); - if (ret) - goto free_host; - if (priv->caps & UNIPHIER_SD_CAP_EXTENDED_IP) host->dma_ops = &uniphier_sd_internal_dma_ops; else @@ -646,8 +641,15 @@ static int uniphier_sd_probe(struct plat if (ret) goto free_host; + ret = devm_request_irq(dev, irq, tmio_mmc_irq, IRQF_SHARED, + dev_name(dev), host); + if (ret) + goto remove_host; + return 0; +remove_host: + tmio_mmc_host_remove(host); free_host: tmio_mmc_host_free(host);