From patchwork Tue Jun 16 15:34:06 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224524 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 58B48C433E1 for ; Tue, 16 Jun 2020 15:38:32 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 356D820B1F for ; Tue, 16 Jun 2020 15:38:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592321912; bh=z8VABR2iloijjO5oU3eoMWMuhLAhwBXfYG9CbcWJDuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ZeDkMK/QAZYe304yNVI42EhJslOHDXdlSPHuuSX94Xz1AWJ0er3l4BRTOfYrj1WJ+ AkCLHs/Hu1Zb4c3NjPi4WRjU+FWP5rs4TwI60sY0DoapWiTxhZuEiLzR6w3NHvXF13 WgMArHwDuASvHGPV8uqcGjcGQrZ6epX65QS+aEBs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730645AbgFPPia (ORCPT ); Tue, 16 Jun 2020 11:38:30 -0400 Received: from mail.kernel.org ([198.145.29.99]:50982 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729811AbgFPPi3 (ORCPT ); Tue, 16 Jun 2020 11:38:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E1BAC20B1F; Tue, 16 Jun 2020 15:38:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1592321909; bh=z8VABR2iloijjO5oU3eoMWMuhLAhwBXfYG9CbcWJDuk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hEHJSAqSyYTuyqcsv3Zv/twv+ays4Q9pFkg92VMKmy4PvBhfr3qtQBQEj+RnXmMUW TPebtlzC1rXoDe3SB1jRM21dKVL0xBnIV+15Q2mKDtvAR5OjQarVW9GV+6RrvtKFhc kK4FW1t5hhm4eaMNJSiBe4xGZQnY02r4jsuJimn0= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , "Rafael J. Wysocki" Subject: [PATCH 5.4 062/134] ACPI: sysfs: Fix reference count leak in acpi_sysfs_add_hotplug_profile() Date: Tue, 16 Jun 2020 17:34:06 +0200 Message-Id: <20200616153103.744249070@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200616153100.633279950@linuxfoundation.org> References: <20200616153100.633279950@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiushi Wu commit 6e6c25283dff866308c87b49434c7dbad4774cc0 upstream. kobject_init_and_add() takes reference even when it fails. Thus, when kobject_init_and_add() returns an error, kobject_put() must be called to properly clean up the kobject. Fixes: 3f8055c35836 ("ACPI / hotplug: Introduce user space interface for hotplug profiles") Signed-off-by: Qiushi Wu Cc: 3.10+ # 3.10+ Signed-off-by: Rafael J. Wysocki Signed-off-by: Greg Kroah-Hartman --- drivers/acpi/sysfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) --- a/drivers/acpi/sysfs.c +++ b/drivers/acpi/sysfs.c @@ -993,8 +993,10 @@ void acpi_sysfs_add_hotplug_profile(stru error = kobject_init_and_add(&hotplug->kobj, &acpi_hotplug_profile_ktype, hotplug_kobj, "%s", name); - if (error) + if (error) { + kobject_put(&hotplug->kobj); goto err_out; + } kobject_uevent(&hotplug->kobj, KOBJ_ADD); return;