From patchwork Tue Jun 9 17:45:49 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 187688 Delivered-To: patch@linaro.org Received: by 2002:a92:cf06:0:0:0:0:0 with SMTP id c6csp764990ilo; Tue, 9 Jun 2020 10:57:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwFN++of5CU1bB6yQPb4Vt1YSpNgRv4aA1M+QyFmvPT5b4AuNWqVwlL0KD9uZrFuCWzrDwc X-Received: by 2002:a17:906:470b:: with SMTP id y11mr27403586ejq.182.1591725476341; Tue, 09 Jun 2020 10:57:56 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591725476; cv=none; d=google.com; s=arc-20160816; b=Op+DdwoKs5WRiwIYDyqyo75MnFVWEba9TztqHfIalzNK0MBH+YDeHehDc+Ih4K21Al RrDNSpxliuMljKvM5p0NV/z2xpHtbb1gBobzgHpOKa9iS2D38CDiw5weIw0gWdRMWr1z /jIzkqIbjimSKlR41akvuOyQqc0vht5ZKmxsyZlviWC1XG3xdl+FvG65xhxN7ZEwnajA pukbuzhhQiApMNbQEabY6UYCEOzVNLHivBoFcyfy6nJlRL5nvTdcgtJMW2r/cYJK8KL/ RZTeSqK3MfWVYYzoqo9tl6H+Dm9J6XQzF/T8pP11hybd/1cI1JCavICif2KGVby+wEF3 8isw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=/rtbpW0aQEeZ4NFcx2rYrdvLKJmdYcGqqwuOKRuwTdk=; b=zbU5PETt8zbMte5VYp9AW95JWbsROHdM2iXXGfDUskaVu3EKE2lWJ8OENSoDZ9bBV1 6e3JbQx43taAh3QL5q8zeP5QayMlfDQOd5HZBJOAmc2FmuqET3Og8OU8EBqUq+i4o4sl q8Lr29pqT1dyE8fXOYAPtopWVnG85g79Sxmtv5ZNKn8EQtIHLOVeyq7oAt32ijGpD7lI 5NL6UVtRDdIOSyqSM6blbgUV2GBW/6nUQ8LTNsvn17ioMOeQ4XnH61TOFteSMzYTAejZ 7psteXF2NIr1QOgjIzVhdgj0Yd6YEue69sLdNezW5OtM+ZOPml60QSdzOde+UH/TsI5E h4lA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aDR2e7mt; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id s1si10826556edw.362.2020.06.09.10.57.55; Tue, 09 Jun 2020 10:57:56 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=aDR2e7mt; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733280AbgFIRzp (ORCPT + 15 others); Tue, 9 Jun 2020 13:55:45 -0400 Received: from mail.kernel.org ([198.145.29.99]:48066 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728287AbgFIRzl (ORCPT ); Tue, 9 Jun 2020 13:55:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D489B207ED; Tue, 9 Jun 2020 17:55:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725341; bh=mlChgyTv5SQLeyzNVZm89cxyxj49nT+0TF3uaH4MMaI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aDR2e7mt4vGab1oHjKGzbpA5PTPHPsDbdwKAZdgPKlG+1dVwF/9u8nUNhi3PYOrOO GRwbZypOWNyC7vj3LRyIiejuY31CBz4dFVnRAan3dko7ZgjXoAblsekv+6PYC9IhEh HQMXeaD+IKgLAr7gOTsuMhecKuu4u3hVOKnS41Tw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Douglas Anderson Subject: [PATCH 5.7 18/24] nvmem: qfprom: remove incorrect write support Date: Tue, 9 Jun 2020 19:45:49 +0200 Message-Id: <20200609174150.803536448@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174149.255223112@linuxfoundation.org> References: <20200609174149.255223112@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla commit 8d9eb0d6d59a5d7028c80a30831143d3e75515a7 upstream. qfprom has different address spaces for read and write. Reads are always done from corrected address space, where as writes are done on raw address space. Writing to corrected address space is invalid and ignored, so it does not make sense to have this support in the driver which only supports corrected address space regions at the moment. Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") Signed-off-by: Srinivas Kandagatla Reviewed-by: Douglas Anderson Cc: stable Link: https://lore.kernel.org/r/20200522113341.7728-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/nvmem/qfprom.c | 14 -------------- 1 file changed, 14 deletions(-) --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -27,25 +27,11 @@ static int qfprom_reg_read(void *context return 0; } -static int qfprom_reg_write(void *context, - unsigned int reg, void *_val, size_t bytes) -{ - struct qfprom_priv *priv = context; - u8 *val = _val; - int i = 0, words = bytes; - - while (words--) - writeb(*val++, priv->base + reg + i++); - - return 0; -} - static struct nvmem_config econfig = { .name = "qfprom", .stride = 1, .word_size = 1, .reg_read = qfprom_reg_read, - .reg_write = qfprom_reg_write, }; static int qfprom_probe(struct platform_device *pdev)