From patchwork Tue Jun 9 17:44:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 187698 Delivered-To: patch@linaro.org Received: by 2002:a92:d6c9:0:0:0:0:0 with SMTP id z9csp784377ilp; Tue, 9 Jun 2020 11:15:09 -0700 (PDT) X-Google-Smtp-Source: ABdhPJxxNcV1u52qbQr2PQgr4L8IyPABcWaZDEL1O8YhXXk2nErsyrCGhLTGSvT5ln0XHra/01/y X-Received: by 2002:a17:906:f189:: with SMTP id gs9mr26097955ejb.203.1591726508931; Tue, 09 Jun 2020 11:15:08 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591726508; cv=none; d=google.com; s=arc-20160816; b=rnnde7MAzGGLZSLBJ8xkCxzTJBc2ljJJRB4SPrSMm7Brd/oo3RuKvBeiei+aH/izHr StJ7hz0B/ohP/31kIV+QcC0fSj94dqxM/jThGpQ341JdouqcclyiOZSeAcKowN/H+us/ RVrtiCqTw0XxztQ8zBlcCPI1QXCpV483Ip7OfsQFIvjC5RL/n9QMKnJ7N785Mg2lhJNT 3xEgGNBIs9T9+BUfCRhljFe4AYAUWZUHGL5wnlUY+Bp/GbeBEwnvuhu8B11xugR5RdEy AbHwEJLXl2xhTuXAMsNAyn/SlncOh96YnfLwUyht5UZr0eTUlULZy76qX2zhe8++lg4/ x8QA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=k7hMpwLWWbWrOKFN5Q272UymqoQoHsP4GxhWCnig0v4=; b=laDcRQ0SKvYp5AD1lZ+AGIomUJBhlmsrXt10VcnQ5cyblKyrP6HAspRkO35chK8/B/ J7s5OysXSrKW+YoJaIjx7xknHk/J+PyA6CFcghetEsGy5R7REUXyLp1ZyXpZkwBvc7QP U3fJJQvyJz8/w6fiUwZgmDilABfk+k3Ba0yex0FUgco0xfelsKZEuXctPslEHIboWtWG MBkNMlagYsArH3E5boPirX5M3wep0pBNi2+9fn1G99K6DPjwAWanzsTvTA/yjxh2t5hC SpQjGaFy2UzNhp02QDvpxm0hjK9wf6mE9jzud0hSZdNq73eV0wkrDAmzA5zJXCdeFzBi UrYQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lwYixYoh; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id ay19si11361955ejb.372.2020.06.09.11.15.08; Tue, 09 Jun 2020 11:15:08 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=lwYixYoh; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732689AbgFIRub (ORCPT + 15 others); Tue, 9 Jun 2020 13:50:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:37916 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732655AbgFIRu2 (ORCPT ); Tue, 9 Jun 2020 13:50:28 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7204120734; Tue, 9 Jun 2020 17:50:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591725026; bh=GEoeqiGrpGRe3rSrKqJTatBUEbBd+QnjdommEb2Bwuw=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=lwYixYohIHahTjfQ7SUozri52kGI85vpuSi97noRoWhZ2ZQeBJUA2JcCJHxtH6//l bJNy7Gti0rxGYHg7a15da5dI6qAPUPmHRkGs/+HAAhglowIEQPpOat2YppRN6AlzY/ zsaZap6sBa4D0dJzYXNbdt/bl2b5y6EhnkQGlx7I= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Srinivas Kandagatla , Douglas Anderson Subject: [PATCH 4.14 39/46] nvmem: qfprom: remove incorrect write support Date: Tue, 9 Jun 2020 19:44:55 +0200 Message-Id: <20200609174030.310539358@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174022.938987501@linuxfoundation.org> References: <20200609174022.938987501@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Srinivas Kandagatla commit 8d9eb0d6d59a5d7028c80a30831143d3e75515a7 upstream. qfprom has different address spaces for read and write. Reads are always done from corrected address space, where as writes are done on raw address space. Writing to corrected address space is invalid and ignored, so it does not make sense to have this support in the driver which only supports corrected address space regions at the moment. Fixes: 4ab11996b489 ("nvmem: qfprom: Add Qualcomm QFPROM support.") Signed-off-by: Srinivas Kandagatla Reviewed-by: Douglas Anderson Cc: stable Link: https://lore.kernel.org/r/20200522113341.7728-1-srinivas.kandagatla@linaro.org Signed-off-by: Greg Kroah-Hartman --- drivers/nvmem/qfprom.c | 14 -------------- 1 file changed, 14 deletions(-) --- a/drivers/nvmem/qfprom.c +++ b/drivers/nvmem/qfprom.c @@ -30,19 +30,6 @@ static int qfprom_reg_read(void *context return 0; } -static int qfprom_reg_write(void *context, - unsigned int reg, void *_val, size_t bytes) -{ - void __iomem *base = context; - u8 *val = _val; - int i = 0, words = bytes; - - while (words--) - writeb(*val++, base + reg + i++); - - return 0; -} - static int qfprom_remove(struct platform_device *pdev) { struct nvmem_device *nvmem = platform_get_drvdata(pdev); @@ -56,7 +43,6 @@ static struct nvmem_config econfig = { .stride = 1, .word_size = 1, .reg_read = qfprom_reg_read, - .reg_write = qfprom_reg_write, }; static int qfprom_probe(struct platform_device *pdev)