From patchwork Tue Jun 9 17:44:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 187699 Delivered-To: patch@linaro.org Received: by 2002:a54:30ca:0:0:0:0:0 with SMTP id e10csp639677ecs; Tue, 9 Jun 2020 11:19:44 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwMypWq0C8ITI1elKQfQs7QhOrD9ykg9fnNqLb1ia5QuSfFRcPDawCBkuzcj4+r6UamY507 X-Received: by 2002:aa7:d290:: with SMTP id w16mr28770052edq.178.1591726784265; Tue, 09 Jun 2020 11:19:44 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1591726784; cv=none; d=google.com; s=arc-20160816; b=WoIK55kEuoXCfKhH0S8AY1ClzNJyYI6FAWJxakaQ7e9Tn5YbW1HperPw1GwwBpUqUB c3j5gLglBEBIM+Snq2WQG3r9ItY6fPg+iAfVfFKGd7aqegeNg+eYS2becO6Htu8k3e4O UC4/8rRG5w4X2qgHvK2Fzod1B9O0hp5lz/wLn+yCgrSnfW0ErMfK/eQMBmceP/fS6Rpo PegNHXHistdcvKBa8p1F4DX2CWoXmJqNhKmqvO5GFrBiKa+jhBsjpLjxE9/3E4yrKl7c LsdcnjLS4LGQ49FM4dM3Ucs8ZLhxdlTf8f1dPg7VIPFlUB4X/FOZOI/SN4MDZQwxmOrU xWVg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=FeK00y+UNYPXHViSZ0XKJy/quSL0PYbx/sw+RyGXbBU=; b=JFWLVmquJEfH/P0TGerCyt92s3rw80Ev33ZOl5Lls4MxLseKHUH131scutUfrVzFAk vkQsWLwSjH07197Mq2h0srsxGFHY0g7MGa4TKbqrJuXdnluxl0EFuLTeaOhtcB0vee22 2IBcyleehzkXkR7QvnU61TJV+TOeDk0lTg2we36vom3XbZjKxtdvnk22MlGeQ1o2ycRs /9YvwBoBPbRbhPptQQhHHz54BOhFdJu07NYUskxCjRYTuz4Q196E0/Yg//gbKdalm3hS 4AI86n4QUp80DvR/yb9g3WYZTVWJjSCeWO1I0VUu9PSPRB60Ypk7SZCu/uvS2VcnB6Ck 16Gg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eoc7WEJs; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [23.128.96.18]) by mx.google.com with ESMTP id l10si11034008ejb.576.2020.06.09.11.19.44; Tue, 09 Jun 2020 11:19:44 -0700 (PDT) Received-SPF: pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) client-ip=23.128.96.18; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Eoc7WEJs; spf=pass (google.com: domain of stable-owner@vger.kernel.org designates 23.128.96.18 as permitted sender) smtp.mailfrom=stable-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731234AbgFISTc (ORCPT + 15 others); Tue, 9 Jun 2020 14:19:32 -0400 Received: from mail.kernel.org ([198.145.29.99]:36004 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732544AbgFIRtl (ORCPT ); Tue, 9 Jun 2020 13:49:41 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 3C2FE20812; Tue, 9 Jun 2020 17:49:40 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591724980; bh=mVl9YgrtiKcOe6VHrWSY6aDgR5QeahVoj7ufwEgl4dc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Eoc7WEJsKPYfJ9bXd/KhhCwt/DzXPurbyHNWKvsIDHj/Z8OjaunU/BNBgLoZAjtCm vV4Itxi15HHobzqSb3jN8MIXR3REadk0V40NPmRxfVOARfkf2UnQELvGvsK6m2Ik48 Ha6Mg/7MdEK7tLHeGLjsitKGjZ9Dhh8O0+lyhPJQ= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, fengsheng , Xinwei Kong , Mark Brown , Sasha Levin Subject: [PATCH 4.14 04/46] spi: dw: use "smp_mb()" to avoid sending spi data error Date: Tue, 9 Jun 2020 19:44:20 +0200 Message-Id: <20200609174023.282147985@linuxfoundation.org> X-Mailer: git-send-email 2.27.0 In-Reply-To: <20200609174022.938987501@linuxfoundation.org> References: <20200609174022.938987501@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Xinwei Kong [ Upstream commit bfda044533b213985bc62bd7ca96f2b984d21b80 ] Because of out-of-order execution about some CPU architecture, In this debug stage we find Completing spi interrupt enable -> prodrucing TXEI interrupt -> running "interrupt_transfer" function will prior to set "dw->rx and dws->rx_end" data, so this patch add memory barrier to enable dw->rx and dw->rx_end to be visible and solve to send SPI data error. eg: it will fix to this following low possibility error in testing environment which using SPI control to connect TPM Modules kernel: tpm tpm0: Operation Timed out kernel: tpm tpm0: tpm_relinquish_locality: : error -1 Signed-off-by: fengsheng Signed-off-by: Xinwei Kong Link: https://lore.kernel.org/r/1578019930-55858-1-git-send-email-kong.kongxinwei@hisilicon.com Signed-off-by: Mark Brown Signed-off-by: Sasha Levin --- drivers/spi/spi-dw.c | 3 +++ 1 file changed, 3 insertions(+) -- 2.25.1 diff --git a/drivers/spi/spi-dw.c b/drivers/spi/spi-dw.c index b461200871f8..cbdad3c4930f 100644 --- a/drivers/spi/spi-dw.c +++ b/drivers/spi/spi-dw.c @@ -305,6 +305,9 @@ static int dw_spi_transfer_one(struct spi_master *master, dws->len = transfer->len; spin_unlock_irqrestore(&dws->buf_lock, flags); + /* Ensure dw->rx and dw->rx_end are visible */ + smp_mb(); + spi_enable_chip(dws, 0); /* Handle per transfer options for bpw and speed */