[5.4,13/38] net: dsa: mt7530: set CPU port to fallback mode

Message ID	20200605140253.364735702@linuxfoundation.org
State	Superseded
Headers	show Return-Path: <SRS0=taFX=7S=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, DENG Qingfang <dqfext@gmail.com>, Florian Fainelli <f.fainelli@gmail.com>, "David S. Miller" <davem@davemloft.net> Subject: [PATCH 5.4 13/38] net: dsa: mt7530: set CPU port to fallback mode Date: Fri, 5 Jun 2020 16:14:56 +0200 Message-Id: <20200605140253.364735702@linuxfoundation.org> In-Reply-To: <20200605140252.542768750@linuxfoundation.org> References: <20200605140252.542768750@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk
Series	None \| expand [5.4,04/38] HID: multitouch: enable multi-input as a quirk for some devices [5.4,05/38] HID: i2c-hid: add Schneider SCL142ALM to descriptor override [5.4,09/38] mmc: fix compilation of user API [5.4,12/38] scsi: ufs: Release clock if DMA map fails [5.4,13/38] net: dsa: mt7530: set CPU port to fallback mode [5.4,15/38] drm/i915: fix port checks for MST support on gen >= 11 [5.4,16/38] scsi: hisi_sas: Check sas_port before using it [5.4,18/38] powerpc/xmon: Restrict when kernel is locked down [5.4,21/38] s390/ftrace: save traced function caller [5.4,23/38] RDMA/qedr: Fix synchronization methods and memory leaks in qedr [5.4,24/38] ARC: Fix ICCM & DCCM runtime size checks [5.4,27/38] scsi: pm: Balance pm_only counter of request queue during system resume [5.4,29/38] io_uring: initialize ctx->sqo_wait earlier [5.4,30/38] x86/mmiotrace: Use cpumask_available() for cpumask_var_t variables [5.4,31/38] net: bmac: Fix read of MAC address from ROM [5.4,33/38] s390/mm: fix set_huge_pte_at() for empty ptes [5.4,35/38] net/ethernet/freescale: rework quiesce/activate for ucc_geth [5.4,38/38] net: smsc911x: Fix runtime PM imbalance on error

Message ID

20200605140253.364735702@linuxfoundation.org

State

Superseded

Headers

From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: linux-kernel@vger.kernel.org
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	stable@vger.kernel.org, DENG Qingfang <dqfext@gmail.com>,
	Florian Fainelli <f.fainelli@gmail.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: [PATCH 5.4 13/38] net: dsa: mt7530: set CPU port to fallback mode
Date: Fri,  5 Jun 2020 16:14:56 +0200
Message-Id: <20200605140253.364735702@linuxfoundation.org>
In-Reply-To: <20200605140252.542768750@linuxfoundation.org>
References: <20200605140252.542768750@linuxfoundation.org>
User-Agent: quilt/0.66
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Sender: stable-owner@vger.kernel.org
Precedence: bulk

Series

None | expand

Commit Message

Greg KH June 5, 2020, 2:14 p.m. UTC

From: DENG Qingfang <dqfext@gmail.com>

commit 38152ea37d8bdaffa22603e0a5b5b86cfa8714c9 upstream.

Currently, setting a bridge's self PVID to other value and deleting
the default VID 1 renders untagged ports of that VLAN unable to talk to
the CPU port:

	bridge vlan add dev br0 vid 2 pvid untagged self
	bridge vlan del dev br0 vid 1 self
	bridge vlan add dev sw0p0 vid 2 pvid untagged
	bridge vlan del dev sw0p0 vid 1
	# br0 cannot send untagged frames out of sw0p0 anymore

That is because the CPU port is set to security mode and its PVID is
still 1, and untagged frames are dropped due to VLAN member violation.

Set the CPU port to fallback mode so untagged frames can pass through.

Fixes: 83163f7dca56 ("net: dsa: mediatek: add VLAN support for MT7530")
Signed-off-by: DENG Qingfang <dqfext@gmail.com>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

---
 drivers/net/dsa/mt7530.c |   11 ++++++++---
 drivers/net/dsa/mt7530.h |    6 ++++++
 2 files changed, 14 insertions(+), 3 deletions(-)

--- a/drivers/net/dsa/mt7530.c
+++ b/drivers/net/dsa/mt7530.c
@@ -818,10 +818,15 @@  mt7530_port_set_vlan_aware(struct dsa_sw
 		   PCR_MATRIX_MASK, PCR_MATRIX(MT7530_ALL_MEMBERS));
 
 	/* Trapped into security mode allows packet forwarding through VLAN
-	 * table lookup.
+	 * table lookup. CPU port is set to fallback mode to let untagged
+	 * frames pass through.
 	 */
-	mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
-		   MT7530_PORT_SECURITY_MODE);
+	if (dsa_is_cpu_port(ds, port))
+		mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
+			   MT7530_PORT_FALLBACK_MODE);
+	else
+		mt7530_rmw(priv, MT7530_PCR_P(port), PCR_PORT_VLAN_MASK,
+			   MT7530_PORT_SECURITY_MODE);
 
 	/* Set the port as a user port which is to be able to recognize VID
 	 * from incoming packets before fetching entry within the VLAN table.
--- a/drivers/net/dsa/mt7530.h
+++ b/drivers/net/dsa/mt7530.h
@@ -148,6 +148,12 @@  enum mt7530_port_mode {
 	/* Port Matrix Mode: Frames are forwarded by the PCR_MATRIX members. */
 	MT7530_PORT_MATRIX_MODE = PORT_VLAN(0),
 
+	/* Fallback Mode: Forward received frames with ingress ports that do
+	 * not belong to the VLAN member. Frames whose VID is not listed on
+	 * the VLAN table are forwarded by the PCR_MATRIX members.
+	 */
+	MT7530_PORT_FALLBACK_MODE = PORT_VLAN(1),
+
 	/* Security Mode: Discard any frame due to ingress membership
 	 * violation or VID missed on the VLAN table.
 	 */

[5.4,13/38] net: dsa: mt7530: set CPU port to fallback mode

Commit Message

Patch