From patchwork Mon Jun 1 17:54:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 225077 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 90443C433DF for ; Mon, 1 Jun 2020 18:09:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 69B252077D for ; Mon, 1 Jun 2020 18:09:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034969; bh=aYhFCPraAuuhSNT615HvbyUmvG8NskDq5ppqHhOLMQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=clwA5da2TiPJuCd6qpr+j12bXAPWOvyexuhU7LR+86z9vMp1z5mXXswtfjedWAS5+ nk1Lki1wE3MThmuc3nSgwBHKujX3BT5h2V++41p8zsA+bQUv9TaonSDot63hK5pnkr K9NLp3gcsMk1mEg3YF9nU7T/24NfTWdE7ShtGzuQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730391AbgFASJ2 (ORCPT ); Mon, 1 Jun 2020 14:09:28 -0400 Received: from mail.kernel.org ([198.145.29.99]:55834 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730873AbgFASJZ (ORCPT ); Mon, 1 Jun 2020 14:09:25 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id E9CFF2068D; Mon, 1 Jun 2020 18:09:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034964; bh=aYhFCPraAuuhSNT615HvbyUmvG8NskDq5ppqHhOLMQY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Cgb1HHfmeUsRy7FRCaDWXDpgqGY47Bu5+P6N4ZBlpBRVw7GOTIp/82eOsqu3uuZ+Q Aan0p+gICC9Oe1lYkJNUIr8vJja47lq+C9GNSrWJNaYpokyr0LMtIzzhsnhEhmT6aa UjuSahbtqnoRtv7eEz+IzTieOM9pak/H1Gc64Azk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Lutomirski , "Eric W. Biederman" , Sasha Levin Subject: [PATCH 5.4 090/142] exec: Always set cap_ambient in cap_bprm_set_creds Date: Mon, 1 Jun 2020 19:54:08 +0200 Message-Id: <20200601174047.286596223@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174037.904070960@linuxfoundation.org> References: <20200601174037.904070960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric W. Biederman [ Upstream commit a4ae32c71fe90794127b32d26d7ad795813b502e ] An invariant of cap_bprm_set_creds is that every field in the new cred structure that cap_bprm_set_creds might set, needs to be set every time to ensure the fields does not get a stale value. The field cap_ambient is not set every time cap_bprm_set_creds is called, which means that if there is a suid or sgid script with an interpreter that has neither the suid nor the sgid bits set the interpreter should be able to accept ambient credentials. Unfortuantely because cap_ambient is not reset to it's original value the interpreter can not accept ambient credentials. Given that the ambient capability set is expected to be controlled by the caller, I don't think this is particularly serious. But it is definitely worth fixing so the code works correctly. I have tested to verify my reading of the code is correct and the interpreter of a sgid can receive ambient capabilities with this change and cannot receive ambient capabilities without this change. Cc: stable@vger.kernel.org Cc: Andy Lutomirski Fixes: 58319057b784 ("capabilities: ambient capabilities") Signed-off-by: "Eric W. Biederman" Signed-off-by: Sasha Levin --- security/commoncap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/security/commoncap.c b/security/commoncap.c index f4ee0ae106b2..0ca31c8bc0b1 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -812,6 +812,7 @@ int cap_bprm_set_creds(struct linux_binprm *bprm) int ret; kuid_t root_uid; + new->cap_ambient = old->cap_ambient; if (WARN_ON(!cap_ambient_invariant_ok(old))) return -EPERM;