From patchwork Mon Jun 1 17:53:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 225083 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE174C433E0 for ; Mon, 1 Jun 2020 18:08:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id AF55920E65 for ; Mon, 1 Jun 2020 18:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034883; bh=SSr626oosF3ax4S4mvuIs1Z3CkLSI8JeRhlwsAREDNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=dwMjiNOKCYcwZDy/3huEdVGReW3o9tOLlxX6k5ScrGEQPyBeOm/zRF5IqXB5s+he2 Pdq4xuJU0nwoMdvwAWRpCzsCvzNBDMsiXUR+UWP+QV91wX+GvpAvzdL9SgK4ZMynW1 2MqI2ZDL1Fy2IxUuUrK2pB1nDLxhWFVyJzfWv4RE= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730661AbgFASIC (ORCPT ); Mon, 1 Jun 2020 14:08:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:54028 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730658AbgFASIB (ORCPT ); Mon, 1 Jun 2020 14:08:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B2491206E2; Mon, 1 Jun 2020 18:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034881; bh=SSr626oosF3ax4S4mvuIs1Z3CkLSI8JeRhlwsAREDNo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=fxhHEtyQs4scqm7Pb4Bv8qADLXRh+wbJrx55azA4RYo4GYr8rV7ENBC9o1BDXOMek RH/nYphoGB6p1WJvFkWUOSXPPQXZGUt424P2teQ6EZ65LmjpJCOuHMKSZXb5Y75kG+ V48qtQeEcZtfd0CwU13SdjSGN9c1ls78Q3vyl9dM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Hulk Robot , Kefeng Wang , Palmer Dabbelt , Sasha Levin Subject: [PATCH 5.4 053/142] riscv: stacktrace: Fix undefined reference to `walk_stackframe Date: Mon, 1 Jun 2020 19:53:31 +0200 Message-Id: <20200601174043.309752393@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174037.904070960@linuxfoundation.org> References: <20200601174037.904070960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Kefeng Wang [ Upstream commit 0502bee37cdef755d63eee60236562e5605e2480 ] Drop static declaration to fix following build error if FRAME_POINTER disabled, riscv64-linux-ld: arch/riscv/kernel/perf_callchain.o: in function `.L0': perf_callchain.c:(.text+0x2b8): undefined reference to `walk_stackframe' Reported-by: Hulk Robot Signed-off-by: Kefeng Wang Signed-off-by: Palmer Dabbelt Signed-off-by: Sasha Levin --- arch/riscv/kernel/stacktrace.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/riscv/kernel/stacktrace.c b/arch/riscv/kernel/stacktrace.c index 0940681d2f68..19e46f4160cc 100644 --- a/arch/riscv/kernel/stacktrace.c +++ b/arch/riscv/kernel/stacktrace.c @@ -63,7 +63,7 @@ void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, #else /* !CONFIG_FRAME_POINTER */ -static void notrace walk_stackframe(struct task_struct *task, +void notrace walk_stackframe(struct task_struct *task, struct pt_regs *regs, bool (*fn)(unsigned long, void *), void *arg) { unsigned long sp, pc;