From patchwork Mon Jun 1 17:54:18 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 224902 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 40BC5C433E0 for ; Mon, 1 Jun 2020 18:54:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 05F6820679 for ; Mon, 1 Jun 2020 18:54:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037656; bh=u9RbMJt+W+v9l+9TcgBJ9HuUlcKo4R+C/yU5x9oNlvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=ifc0qNYFX/u1SiNjZL1PN6oxUwfWhaLb8zL+S7e1vkt9k09NzrtAHMFbxBWyfax7v dvhKv218t+90BXFuFZNteHopcSYhXQzuarWMY5jA5igVMLUgqtdMwE8WZ46PNokrDE y50TbSn6gIXac36TciK1U9qSKSLU384Zsu1XA8Qw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729903AbgFASCO (ORCPT ); Mon, 1 Jun 2020 14:02:14 -0400 Received: from mail.kernel.org ([198.145.29.99]:45280 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729896AbgFASCK (ORCPT ); Mon, 1 Jun 2020 14:02:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id DA2652065C; Mon, 1 Jun 2020 18:02:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034530; bh=u9RbMJt+W+v9l+9TcgBJ9HuUlcKo4R+C/yU5x9oNlvs=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=zN2FRVIDiFYYvVqm/Bh/qEgVoB3nWq3ZXfmSlPSSR0XswRcmmTcBAdW5XJRPIT8Xc VlrqNqcInhF55eQjRflctkWjA9PkLViRpS5KJtbL/3PP5v3Pc3B4zMMxEPaT8LYwOS D1vCRKN9z0d9dnVij5SgL6zyC8M8u0jbJNNgDSkM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Guoqing Jiang , Arnd Bergmann , Guenter Roeck Subject: [PATCH 4.14 73/77] sc16is7xx: move label err_spi to correct section Date: Mon, 1 Jun 2020 19:54:18 +0200 Message-Id: <20200601174028.801093489@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174016.396817032@linuxfoundation.org> References: <20200601174016.396817032@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Guoqing Jiang commit e00164a0f000de893944981f41a568c981aca658 upstream. err_spi is used when SERIAL_SC16IS7XX_SPI is enabled, so make the label only available under SERIAL_SC16IS7XX_SPI option. Otherwise, the below warning appears. drivers/tty/serial/sc16is7xx.c:1523:1: warning: label ‘err_spi’ defined but not used [-Wunused-label] err_spi: ^~~~~~~ Signed-off-by: Guoqing Jiang Fixes: ac0cdb3d9901 ("sc16is7xx: missing unregister/delete driver on error in sc16is7xx_init()") Signed-off-by: Arnd Bergmann Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/sc16is7xx.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/tty/serial/sc16is7xx.c +++ b/drivers/tty/serial/sc16is7xx.c @@ -1524,10 +1524,12 @@ static int __init sc16is7xx_init(void) #endif return ret; +#ifdef CONFIG_SERIAL_SC16IS7XX_SPI err_spi: #ifdef CONFIG_SERIAL_SC16IS7XX_I2C i2c_del_driver(&sc16is7xx_i2c_uart_driver); #endif +#endif err_i2c: uart_unregister_driver(&sc16is7xx_uart); return ret;