From patchwork Mon Jun 1 17:53:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224894 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C504C433E0 for ; Mon, 1 Jun 2020 18:55:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 72DEF20679 for ; Mon, 1 Jun 2020 18:55:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037743; bh=Qgy1DkMyJttUV/EGcXoWIBjsNpldUuS9juZMdzMfCXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xqOZHeZo9BGCkfRoQlsCZyaD7kJkZfNg9fOLoHMJeoHo9/bvshfynQPuN4ilxH/Pg 1tUq/iwQjlwFh6/lmweE9kVbmbHQ9YLMhQyavDtIx/zJLAB9IWWw+LU426tEiCrXAl QfwvaeLbTgniNGY4PwquGqFD26y2eAhllA85TWyA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729748AbgFASBL (ORCPT ); Mon, 1 Jun 2020 14:01:11 -0400 Received: from mail.kernel.org ([198.145.29.99]:44022 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729088AbgFASBK (ORCPT ); Mon, 1 Jun 2020 14:01:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 942912074B; Mon, 1 Jun 2020 18:01:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034470; bh=Qgy1DkMyJttUV/EGcXoWIBjsNpldUuS9juZMdzMfCXQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=KykdM8YfMK7978oQSvS94Rzh9XLKWpqX4hWShhjC6q/0wU2hOjVtMtkk+3MMqjHXk fBHD2q9WrsZSl+T7Z7HOPlCF0T1QNiPKgp97zZPgPrJoNghU8Uc+eYX6cbpLBQw4yD cvNKnrjfFL/dA4npI02rODtXaysH+bPjNNmBj38w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Lutomirski , "Eric W. Biederman" , Sasha Levin Subject: [PATCH 4.14 45/77] exec: Always set cap_ambient in cap_bprm_set_creds Date: Mon, 1 Jun 2020 19:53:50 +0200 Message-Id: <20200601174024.413430570@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174016.396817032@linuxfoundation.org> References: <20200601174016.396817032@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Eric W. Biederman [ Upstream commit a4ae32c71fe90794127b32d26d7ad795813b502e ] An invariant of cap_bprm_set_creds is that every field in the new cred structure that cap_bprm_set_creds might set, needs to be set every time to ensure the fields does not get a stale value. The field cap_ambient is not set every time cap_bprm_set_creds is called, which means that if there is a suid or sgid script with an interpreter that has neither the suid nor the sgid bits set the interpreter should be able to accept ambient credentials. Unfortuantely because cap_ambient is not reset to it's original value the interpreter can not accept ambient credentials. Given that the ambient capability set is expected to be controlled by the caller, I don't think this is particularly serious. But it is definitely worth fixing so the code works correctly. I have tested to verify my reading of the code is correct and the interpreter of a sgid can receive ambient capabilities with this change and cannot receive ambient capabilities without this change. Cc: stable@vger.kernel.org Cc: Andy Lutomirski Fixes: 58319057b784 ("capabilities: ambient capabilities") Signed-off-by: "Eric W. Biederman" Signed-off-by: Sasha Levin --- security/commoncap.c | 1 + 1 file changed, 1 insertion(+) diff --git a/security/commoncap.c b/security/commoncap.c index ae26ef006988..ac031fa39190 100644 --- a/security/commoncap.c +++ b/security/commoncap.c @@ -711,6 +711,7 @@ int cap_bprm_set_creds(struct linux_binprm *bprm) int ret; kuid_t root_uid; + new->cap_ambient = old->cap_ambient; if (WARN_ON(!cap_ambient_invariant_ok(old))) return -EPERM;