From patchwork Mon Jun 1 17:53:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224872 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1271C433DF for ; Mon, 1 Jun 2020 18:58:35 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 736F520679 for ; Mon, 1 Jun 2020 18:58:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037915; bh=cChF2ARnFROjgWHvgMtMTnu9IVOOALLdq4gw/5/d9GY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=BejH0NqjvtT2xtxyXBR2ySlyrHeYPZIRyQU2C1Exw+ic5cgCEZjwONpeB2jc4SPKM bzJD8Zdlsa8s/xMgod9L6b2MY9q74skHYT+m+dka4/OqLJt9rzPxwgY7pFOWWxu65V jBh4P48bOEoofr5O6VRVB2qNWbqU4Mbf+TBCMesw= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729197AbgFAR6d (ORCPT ); Mon, 1 Jun 2020 13:58:33 -0400 Received: from mail.kernel.org ([198.145.29.99]:40492 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729189AbgFAR6b (ORCPT ); Mon, 1 Jun 2020 13:58:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A32C32076B; Mon, 1 Jun 2020 17:58:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034311; bh=cChF2ARnFROjgWHvgMtMTnu9IVOOALLdq4gw/5/d9GY=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=e5JTFwShQyrKocWYrNceErygGgJmEvbIwC9mi0RZ4WSvFPg5gImMB+X9pUb7VCfVO lXeVgF82ptD39ITPVaJq/hIcqev3Np+TMuEmHpU25zZAPL+4Xp087uLMMdbO2JNmY/ ztEm0iG3kUcPciUw+yavhe6P8g8dJcFIlKrVmAmU= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Chris Chiu , Takashi Iwai , Sasha Levin Subject: [PATCH 4.9 35/61] ALSA: usb-audio: mixer: volume quirk for ESS Technology Asus USB DAC Date: Mon, 1 Jun 2020 19:53:42 +0200 Message-Id: <20200601174018.213700943@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174010.316778377@linuxfoundation.org> References: <20200601174010.316778377@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Chris Chiu [ Upstream commit 4020d1ccbe55bdf67b31d718d2400506eaf4b43f ] The Asus USB DAC is a USB type-C audio dongle for connecting to the headset and headphone. The volume minimum value -23040 which is 0xa600 in hexadecimal with the resolution value 1 indicates this should be endianness issue caused by the firmware bug. Add a volume quirk to fix the volume control problem. Also fixes this warning: Warning! Unlikely big volume range (=23040), cval->res is probably wrong. [5] FU [Headset Capture Volume] ch = 1, val = -23040/0/1 Warning! Unlikely big volume range (=23040), cval->res is probably wrong. [7] FU [Headset Playback Volume] ch = 1, val = -23040/0/1 Signed-off-by: Chris Chiu Cc: Link: https://lore.kernel.org/r/20200526062613.55401-1-chiu@endlessm.com Signed-off-by: Takashi Iwai Signed-off-by: Sasha Levin --- sound/usb/mixer.c | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/sound/usb/mixer.c b/sound/usb/mixer.c index e2f62362a0b0..024864ce3f76 100644 --- a/sound/usb/mixer.c +++ b/sound/usb/mixer.c @@ -980,6 +980,14 @@ static void volume_control_quirks(struct usb_mixer_elem_info *cval, cval->res = 384; } break; + case USB_ID(0x0495, 0x3042): /* ESS Technology Asus USB DAC */ + if ((strstr(kctl->id.name, "Playback Volume") != NULL) || + strstr(kctl->id.name, "Capture Volume") != NULL) { + cval->min >>= 8; + cval->max = 0; + cval->res = 1; + } + break; } }