From patchwork Mon Jun 1 17:53:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224864 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3820DC433E1 for ; Mon, 1 Jun 2020 18:59:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0DAF220885 for ; Mon, 1 Jun 2020 18:59:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037963; bh=dOPcYIEJZeJxVltWjkdcPYiB+fLx4HejS2Qzk2arYxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=Nj9OR7MeyRPqdqFb7qtJbggGts6MwLbau8Vv3PAGApmmDUsG/9iVl+FA8L0WgDhlS TDQz7Egt3hvvnW9rtetaXvASg7RRIgfsQDpu58IFepqndwDSuch/0UzLjTsp5CPSkX iyUZ/MglY9BWZB7C4AIoWBbAjGsgrRY2q4WDU9qY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729846AbgFAS7W (ORCPT ); Mon, 1 Jun 2020 14:59:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:38706 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728926AbgFAR5a (ORCPT ); Mon, 1 Jun 2020 13:57:30 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A548F2074B; Mon, 1 Jun 2020 17:57:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034250; bh=dOPcYIEJZeJxVltWjkdcPYiB+fLx4HejS2Qzk2arYxk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=XgB9nQqJfsa7EdAy9mydkqCFR3qZjydZvzfBJkgTN8eWzWltPk7NPvpH8sAFY2H1o aD7vw1tx3wlhh89WJ7S+BAD2jxpjlue6X3/46JqVWV5vOlB8z1QPq91qQpDpE6BblX 2VDwcM0VYcWH6AxKIr/G5PkxXpWt4m7HDxPXOHng= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Qiushi Wu , "David S. Miller" Subject: [PATCH 4.9 10/61] net/mlx4_core: fix a memory leak bug. Date: Mon, 1 Jun 2020 19:53:17 +0200 Message-Id: <20200601174013.658132864@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601174010.316778377@linuxfoundation.org> References: <20200601174010.316778377@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Qiushi Wu commit febfd9d3c7f74063e8e630b15413ca91b567f963 upstream. In function mlx4_opreq_action(), pointer "mailbox" is not released, when mlx4_cmd_box() return and error, causing a memory leak bug. Fix this issue by going to "out" label, mlx4_free_cmd_mailbox() can free this pointer. Fixes: fe6f700d6cbb ("net/mlx4_core: Respond to operation request by firmware") Signed-off-by: Qiushi Wu Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlx4/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/ethernet/mellanox/mlx4/fw.c +++ b/drivers/net/ethernet/mellanox/mlx4/fw.c @@ -2704,7 +2704,7 @@ void mlx4_opreq_action(struct work_struc if (err) { mlx4_err(dev, "Failed to retrieve required operation: %d\n", err); - return; + goto out; } MLX4_GET(modifier, outbox, GET_OP_REQ_MODIFIER_OFFSET); MLX4_GET(token, outbox, GET_OP_REQ_TOKEN_OFFSET);