From patchwork Mon Jun 1 17:53:53 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 224858 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05692C433DF for ; Mon, 1 Jun 2020 18:59:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D86C4206E2 for ; Mon, 1 Jun 2020 18:59:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591037994; bh=jmdWX0SZuQKksabiIIN5yQmlcrrl6R9CUJOj0zjDu6A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=uylrP5asM/QUuj082D2TmgASOthLWM/2+o/2W+ro0X8NWnw+0VMxiyY4IAlZO951w WvSWAuKesU62MhvGAI8qG9d3OkkCL4UunWXKasT9hE1CIAPhunnOAcJp3BRAKwvM6q T/Uo/npsbnWOb+thX1kIsSkhLwqmgRJ0tX8lOALs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728766AbgFAR4z (ORCPT ); Mon, 1 Jun 2020 13:56:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:37742 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728760AbgFAR4y (ORCPT ); Mon, 1 Jun 2020 13:56:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 89680207D0; Mon, 1 Jun 2020 17:56:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1591034214; bh=jmdWX0SZuQKksabiIIN5yQmlcrrl6R9CUJOj0zjDu6A=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2p4/EpaiJJOC2dvXsu5e2kArRdbvwaQodzyB0R65L+V/SxTysok9tMlLDNG9I3cfK 7JISn33z+5IIhVNsF4QcnkiYVgOhneltF96ap1oW9NTZUk8ETI2WCo4fcW7+lZA93E MiIoqyLqotUwl87ojC+5tIJ7pEB3smIaJ9Q7Ur2M= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Julian Calaby , Sudip Mukherjee , Johannes Berg , Guenter Roeck Subject: [PATCH 4.4 43/48] mac80211: fix memory leak Date: Mon, 1 Jun 2020 19:53:53 +0200 Message-Id: <20200601174004.493887733@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200601173952.175939894@linuxfoundation.org> References: <20200601173952.175939894@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sudip Mukherjee commit ea32f065bd3e3e09f0bcb3042f1664caf6b3e233 upstream. On error we jumped to the error label and returned the error code but we missed releasing sinfo. Fixes: 5fe74014172d ("mac80211: avoid excessive stack usage in sta_info") Reviewed-by: Julian Calaby Signed-off-by: Sudip Mukherjee Signed-off-by: Johannes Berg Cc: Guenter Roeck Signed-off-by: Greg Kroah-Hartman --- net/mac80211/sta_info.c | 1 + 1 file changed, 1 insertion(+) --- a/net/mac80211/sta_info.c +++ b/net/mac80211/sta_info.c @@ -555,6 +555,7 @@ static int sta_info_insert_finish(struct __cleanup_single_sta(sta); out_err: mutex_unlock(&local->sta_mtx); + kfree(sinfo); rcu_read_lock(); return err; }