From patchwork Tue May 26 18:53:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 225231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B96CC433E0 for ; Tue, 26 May 2020 19:28:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 31D2E20776 for ; Tue, 26 May 2020 19:28:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590521336; bh=bTdwv1vyZUg+549OUWqfF6B+jLil2PTqgnQIUtA4yM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=vTd4+Q58Iy7sTm6KYGY3dIhk1kTj1yYGLWJaJ6smDjnGJIYbctM5W0Wg3llP7eI0f C7b0OL8ftwBMtukRnAbkG1FZixKPMs5E9+wyC3FgkmcRUBlI8A3GDCwmGJNm9zhs4X 7k3iAPzH9jvOehM7cTsnMBlbxH4us7+JVk9i5Bzs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2391047AbgEZTCM (ORCPT ); Tue, 26 May 2020 15:02:12 -0400 Received: from mail.kernel.org ([198.145.29.99]:56868 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389115AbgEZTCL (ORCPT ); Tue, 26 May 2020 15:02:11 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 12F562084C; Tue, 26 May 2020 19:02:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1590519731; bh=bTdwv1vyZUg+549OUWqfF6B+jLil2PTqgnQIUtA4yM4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Nt06jzsiE5ZHU2OE53YfNHj/8QFGzwKFOA70hiJVp/B44X9rGby1ZjaUYkJSiI/Gx FhJXztQjOTAC3bA+pvusMcJrLB98MS0MNDIh/T4K6U+XlpOnyC+krp9kjqgqDfCRvD yfSsF7zcv7vZNsunzXVWAPW2u29VAmqX4aAJPG0Q= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, =?utf-8?b?5Lq/5LiA?= , Alexander Usyskin , Tomas Winkler Subject: [PATCH 4.14 54/59] mei: release me_cl object reference Date: Tue, 26 May 2020 20:53:39 +0200 Message-Id: <20200526183923.460766309@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200526183907.123822792@linuxfoundation.org> References: <20200526183907.123822792@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alexander Usyskin commit fc9c03ce30f79b71807961bfcb42be191af79873 upstream. Allow me_cl object to be freed by releasing the reference that was acquired by one of the search functions: __mei_me_cl_by_uuid_id() or __mei_me_cl_by_uuid() Cc: Reported-by: 亿一 Signed-off-by: Alexander Usyskin Signed-off-by: Tomas Winkler Link: https://lore.kernel.org/r/20200512223140.32186-1-tomas.winkler@intel.com Signed-off-by: Greg Kroah-Hartman --- drivers/misc/mei/client.c | 2 ++ 1 file changed, 2 insertions(+) --- a/drivers/misc/mei/client.c +++ b/drivers/misc/mei/client.c @@ -276,6 +276,7 @@ void mei_me_cl_rm_by_uuid(struct mei_dev down_write(&dev->me_clients_rwsem); me_cl = __mei_me_cl_by_uuid(dev, uuid); __mei_me_cl_del(dev, me_cl); + mei_me_cl_put(me_cl); up_write(&dev->me_clients_rwsem); } @@ -297,6 +298,7 @@ void mei_me_cl_rm_by_uuid_id(struct mei_ down_write(&dev->me_clients_rwsem); me_cl = __mei_me_cl_by_uuid_id(dev, uuid, id); __mei_me_cl_del(dev, me_cl); + mei_me_cl_put(me_cl); up_write(&dev->me_clients_rwsem); }