diff mbox series

[5.4,84/90] iommu/virtio: Reverse arguments to list_add

Message ID	20200513094417.937658233@linuxfoundation.org
State	New
Headers	show Return-Path: <SRS0=bVfs=63=vger.kernel.org=stable-owner@kernel.org> From: Greg Kroah-Hartman <gregkh@linuxfoundation.org> To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>, stable@vger.kernel.org, Julia Lawall <Julia.Lawall@inria.fr>, Jean-Philippe Brucker <jean-philippe@linaro.org>, Joerg Roedel <jroedel@suse.de> Subject: [PATCH 5.4 84/90] iommu/virtio: Reverse arguments to list_add Date: Wed, 13 May 2020 11:45:20 +0200 Message-Id: <20200513094417.937658233@linuxfoundation.org> In-Reply-To: <20200513094408.810028856@linuxfoundation.org> References: <20200513094408.810028856@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org Precedence: bulk
Series	None \| expand [5.4,02/90] nvme: refactor nvme_identify_ns_descs error handling [5.4,04/90] tracing/kprobes: Fix a double initialization typo [5.4,06/90] drm/amdgpu: move kfd suspend after ip_suspend_phase1 [5.4,09/90] tty: xilinx_uartps: Fix missing id assignment to the console [5.4,11/90] dp83640: reverse arguments to list_add_tail [5.4,13/90] ipv6: Use global sernum for dst validation with nexthop objects [5.4,16/90] net: dsa: Do not leave DSA master with NULL netdev_ops [5.4,18/90] net: macsec: preserve ingress frame ordering [5.4,21/90] net: stricter validation of untrusted gso packets [5.4,23/90] net/tls: Fix sk_psock refcnt leak in bpf_exec_tx_verdict() [5.4,25/90] net: usb: qmi_wwan: add support for DW5816e [5.4,26/90] nfp: abm: fix a memory leak bug [5.4,28/90] sch_sfq: validate silly quantum values [5.4,31/90] bnxt_en: Fix VF anti-spoof filter setup. [5.4,32/90] bnxt_en: Reduce BNXT_MSIX_VEC_MAX value to supported CQs per PF. [5.4,34/90] bnxt_en: Return error when allocating zero size context memory. [5.4,35/90] bnxt_en: Fix VLAN acceleration handling in bnxt_fix_features(). [5.4,40/90] net: mvpp2: cls: Prevent buffer overflow in mvpp2_ethtool_cls_rule_del() [5.4,43/90] Revert "HID: wacom: generic: read the number of expected touches on a per collection ... [5.4,45/90] HID: wacom: Report 2nd-gen Intuos Pro S center button status over BT [5.4,48/90] USB: serial: garmin_gps: add sanity checking for data length [5.4,49/90] tracing: Add a vmalloc_sync_mappings() for safe measure [5.4,50/90] crypto: arch/nhpoly1305 - process in explicit 4k chunks [5.4,53/90] KVM: arm: vgic: Fix limit condition when writing to GICD_I[CS]ACTIVER [5.4,54/90] KVM: arm64: Fix 32bit PC wrap-around [5.4,56/90] drm: ingenic-drm: add MODULE_DEVICE_TABLE [5.4,59/90] eventpoll: fix missing wakeup for ovflist in ep_poll_callback [5.4,61/90] mm: limit boost_watermark on small zones [5.4,63/90] ceph: demote quotarealm lookup warning to a debug message [5.4,66/90] riscv: set max_pfn to the PFN of the last page [5.4,68/90] batman-adv: fix batadv_nc_random_weight_tq [5.4,69/90] batman-adv: Fix refcnt leak in batadv_show_throughput_override [5.4,71/90] batman-adv: Fix refcnt leak in batadv_v_ogm_process [5.4,73/90] x86/entry/64: Fix unwind hints in kernel exit path [5.4,74/90] x86/entry/64: Fix unwind hints in rewind_stack_do_exit() [5.4,77/90] x86/unwind/orc: Fix error path for bad ORC entry type [5.4,79/90] KVM: x86: Fixes posted interrupt check for IRQs delivery modes [5.4,80/90] arch/x86/kvm/svm/sev.c: change flag passed to GUP fast in sev_pin_memory() [5.4,81/90] netfilter: nat: never update the UDP checksum when its 0 [5.4,83/90] objtool: Fix stack offset tracking for indirect CFAs [5.4,84/90] iommu/virtio: Reverse arguments to list_add [5.4,87/90] bdi: move bdi_dev_name out of line [5.4,88/90] bdi: add a ->dev_name field to struct backing_dev_info [5.4,90/90] fanotify: merge duplicate events on parent and child

Commit Message

Greg KH May 13, 2020, 9:45 a.m. UTC

From: Julia Lawall <Julia.Lawall@inria.fr>

commit fb3637a113349f53830f7d6ca45891b7192cd28f upstream.

Elsewhere in the file, there is a list_for_each_entry with
&vdev->resv_regions as the second argument, suggesting that
&vdev->resv_regions is the list head.  So exchange the
arguments on the list_add call to put the list head in the
second argument.

Fixes: 2a5a31487445 ("iommu/virtio: Add probe request")
Signed-off-by: Julia Lawall <Julia.Lawall@inria.fr>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

Reviewed-by: Jean-Philippe Brucker <jean-philippe@linaro.org>
Link: https://lore.kernel.org/r/1588704467-13431-1-git-send-email-Julia.Lawall@inria.fr
Signed-off-by: Joerg Roedel <jroedel@suse.de>

---
 drivers/iommu/virtio-iommu.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff mbox series

Patch

--- a/drivers/iommu/virtio-iommu.c
+++ b/drivers/iommu/virtio-iommu.c
@@ -454,7 +454,7 @@  static int viommu_add_resv_mem(struct vi
 	if (!region)
 		return -ENOMEM;
 
-	list_add(&vdev->resv_regions, &region->list);
+	list_add(&region->list, &vdev->resv_regions);
 	return 0;
 }