From patchwork Wed May 13 09:44:42 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 226025 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.9 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 29138CA90AF for ; Wed, 13 May 2020 09:47:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0A45523126 for ; Wed, 13 May 2020 09:47:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363276; bh=04SOpmy/nQi3IPuBwWUpHz+7j9p4iDrmYSVTlxJeMQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=tLJgPOTRHP0tfsTRe6HpGG8DGaK+9rXEboh5JHUKSqpTzdXhuhCKtyx0HoxS/m0LU Wwa/zOy72avy5G7e3bvg+ZZ121Og6ZroHqwRdont4qpRwqOas1K++nTcp68/TJGLFw 1c4VrvT4aItioufZTn/SLMVgviXCdvRN0YPMJRJA= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732960AbgEMJrz (ORCPT ); Wed, 13 May 2020 05:47:55 -0400 Received: from mail.kernel.org ([198.145.29.99]:46042 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732954AbgEMJry (ORCPT ); Wed, 13 May 2020 05:47:54 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8127C20769; Wed, 13 May 2020 09:47:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1589363274; bh=04SOpmy/nQi3IPuBwWUpHz+7j9p4iDrmYSVTlxJeMQQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=oj51+2HNvS06f4HOLBsm+Twx23pJAjFeMow/Ipb5EIsRJ7RKTCUKuorFiyIcToTP0 FSAAIjH7ibOk/rw0ZXOq+pPmSuu0CO96GcjhEfPqVqmdUVlBCcKjfJ+KXBdRHPmaGm xyHwdznk+madrane+0l+8ej30d1KRytyVC8MkXKA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Chan , "David S. Miller" Subject: [PATCH 4.19 16/48] bnxt_en: Improve AER slot reset. Date: Wed, 13 May 2020 11:44:42 +0200 Message-Id: <20200513094355.306462715@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200513094351.100352960@linuxfoundation.org> References: <20200513094351.100352960@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Michael Chan [ Upstream commit bae361c54fb6ac6eba3b4762f49ce14beb73ef13 ] Improve the slot reset sequence by disabling the device to prevent bad DMAs if slot reset fails. Return the proper result instead of always PCI_ERS_RESULT_RECOVERED to the caller. Fixes: 6316ea6db93d ("bnxt_en: Enable AER support.") Signed-off-by: Michael Chan Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) --- a/drivers/net/ethernet/broadcom/bnxt/bnxt.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt.c @@ -9300,8 +9300,11 @@ static pci_ers_result_t bnxt_io_slot_res } } - if (result != PCI_ERS_RESULT_RECOVERED && netif_running(netdev)) - dev_close(netdev); + if (result != PCI_ERS_RESULT_RECOVERED) { + if (netif_running(netdev)) + dev_close(netdev); + pci_disable_device(pdev); + } rtnl_unlock(); @@ -9312,7 +9315,7 @@ static pci_ers_result_t bnxt_io_slot_res err); /* non-fatal, continue */ } - return PCI_ERS_RESULT_RECOVERED; + return result; } /**