From patchwork Fri May 8 12:33:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 226125 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AF649C38A2A for ; Fri, 8 May 2020 13:16:18 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6C1FC206B8 for ; Fri, 8 May 2020 13:16:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588943778; bh=VyJB4voVU/kpMkxlpMjovjGyAfsim1CjcFShiatto98=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fq9dr3DRzU15sa5WZVDNWFPwkPsrP6P0aH3RM39wQqUpRSs0T1PJCphd357BUcCaw QShnO9KLoF4hDOa6GXtgSMJR7ObpRygxBuk+lWUAARlU3x2UuBeO2oJuPfZdyw1ZD4 hMyRouDRHYOctFDCa2is0KUSz0amWnqti9vhTC6Q= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729276AbgEHMpT (ORCPT ); Fri, 8 May 2020 08:45:19 -0400 Received: from mail.kernel.org ([198.145.29.99]:44696 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729289AbgEHMpR (ORCPT ); Fri, 8 May 2020 08:45:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 01222208D6; Fri, 8 May 2020 12:45:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941917; bh=VyJB4voVU/kpMkxlpMjovjGyAfsim1CjcFShiatto98=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=vNdQXxJ0obXliMUreX5bxg8KvlhYcdp8QTXfgzsxM9sgyBDz0rC3bobX3AFMZ0O9F 7Ypu1rmX9A2+C4kpdRmaCoxKtCRXsJL+kwr5IhFajL9kXk2u43L+WBbIenRQn9zhOD 0whxOweVButoNX3qHv2l0lKFZ9Yhe1jzqTj6/JVM= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Elad Raz , Jiri Pirko , Ido Schimmel , "David S. Miller" Subject: [PATCH 4.4 223/312] mlxsw: switchx2: Fix ethernet port initialization Date: Fri, 8 May 2020 14:33:34 +0200 Message-Id: <20200508123140.141329888@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Elad Raz commit 7fb6a36bab6b0b158f93eb13faa1b440f8b26009 upstream. When creating an ethernet port fails, we must move the port to disable, otherwise putting the port in switch partition 0 (ETH) or 1 (IB) will always fails. Fixes: 31557f0f9755 ("mlxsw: Introduce Mellanox SwitchX-2 ASIC support") Signed-off-by: Elad Raz Reviewed-by: Jiri Pirko Reviewed-by: Ido Schimmel Signed-off-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- drivers/net/ethernet/mellanox/mlxsw/switchx2.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/net/ethernet/mellanox/mlxsw/switchx2.c +++ b/drivers/net/ethernet/mellanox/mlxsw/switchx2.c @@ -1074,6 +1074,7 @@ err_port_stp_state_set: err_port_admin_status_set: err_port_mtu_set: err_port_speed_set: + mlxsw_sx_port_swid_set(mlxsw_sx_port, MLXSW_PORT_SWID_DISABLED_PORT); err_port_swid_set: err_port_system_port_mapping_set: port_not_usable: