From patchwork Fri May 8 12:32:43 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 226266 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 369CCC47247 for ; Fri, 8 May 2020 12:43:10 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0CD1420731 for ; Fri, 8 May 2020 12:43:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941790; bh=zqQDo8kzp6NEGA2JyNikZe5le3hBvC/lDrV5X0I49l4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=aCbR4f7d4XDyEhq2cg/4phy1+lreb0JFjejqkTPt6mskB1m1G3RZoMxNJq5iV5tzB zZDWkP/TsYo43s8WjDa2kyDBQoRlyMaxe6VIVUOyGh6lxvC6dqdESB/DQ9ZxM0J+xL RIsrqxyzKJaWG7Dg6HrqrPQQhThJywXhswcFKHqc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728190AbgEHMnJ (ORCPT ); Fri, 8 May 2020 08:43:09 -0400 Received: from mail.kernel.org ([198.145.29.99]:40694 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729039AbgEHMnI (ORCPT ); Fri, 8 May 2020 08:43:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7C2BA24971; Fri, 8 May 2020 12:43:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941788; bh=zqQDo8kzp6NEGA2JyNikZe5le3hBvC/lDrV5X0I49l4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bhZSqZzzSyWC4anx/7fADtt8O51rbpG3qBDBY9r2q1NE2/PhlT3IHinyjWXvdcHWa iwqwXRbnd9GqxA0++C+JPjwSmg/X9Z+MIkJjsRzeENcW98DFHOt1uzUsAlILuTuV7N FuqZeQhQ8+khzM+T1trP3kd1RunBMtVLZmssDMq8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dan Carpenter , Hans Verkuil , Mauro Carvalho Chehab Subject: [PATCH 4.4 172/312] [media] cx23885: uninitialized variable in cx23885_av_work_handler() Date: Fri, 8 May 2020 14:32:43 +0200 Message-Id: <20200508123136.598357947@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dan Carpenter commit 60587bd0680507f48ae3a7360983228fd207de8a upstream. The "handled" variable could be uninitialized if the interrupt_service_routine() call back hasn't been implimented or if it has been implemented but doesn't initialize "handled" to zero at the start. For example, adv76xx_isr() only sets "handled" to true. Fixes: 44b153ca639f ('[media] m5mols: Add ISO sensitivity controls') Signed-off-by: Dan Carpenter Signed-off-by: Hans Verkuil Signed-off-by: Mauro Carvalho Chehab Signed-off-by: Greg Kroah-Hartman --- drivers/media/pci/cx23885/cx23885-av.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/media/pci/cx23885/cx23885-av.c +++ b/drivers/media/pci/cx23885/cx23885-av.c @@ -24,7 +24,7 @@ void cx23885_av_work_handler(struct work { struct cx23885_dev *dev = container_of(work, struct cx23885_dev, cx25840_work); - bool handled; + bool handled = false; v4l2_subdev_call(dev->sd_cx25840, core, interrupt_service_routine, PCI_MSK_AV_CORE, &handled);