From patchwork Fri May 8 12:30:39 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 226293 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86F35C38A2A for ; Fri, 8 May 2020 12:38:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 6A20C21473 for ; Fri, 8 May 2020 12:38:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941484; bh=yKbj0rJYXNByAGAysaCB5cEhbLfEKxdcr1mvomYSmG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xVe4y4QxHw+hfE9e00OtqEFc1vjTACAjDl58j9UEkbqPy+eXQTR2DwwXqGR8+vlcV qH8Ue0FfPQtz9eV9MG7TGh0Sn7XMGKstTTTOB9754mSEIPC+muqhieZiTwoW8OgJAF cAtY/JS3VgwlkK9H/xAcLh1Z626LAOgF4Jsvz3eg= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728304AbgEHMiD (ORCPT ); Fri, 8 May 2020 08:38:03 -0400 Received: from mail.kernel.org ([198.145.29.99]:52762 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728300AbgEHMiC (ORCPT ); Fri, 8 May 2020 08:38:02 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5DC26207DD; Fri, 8 May 2020 12:38:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588941481; bh=yKbj0rJYXNByAGAysaCB5cEhbLfEKxdcr1mvomYSmG4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aN+Z6em/+gsNQJPiCQ0GNpRh5RX0VNJ6sIuCy5YaSu6FoZ4jLRswTLlv3Vma9EDYb srEFEth9IkpRXXuEyhhhsnphPea/oGw5EB4NCH8TXkXjNbOO/oJtQjI5q8UenULgd1 8r2spbvmGn7DNd92C8fQJuLdp5s5F8yK4HQOx2iE= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Andy Shevchenko , Takashi Iwai Subject: [PATCH 4.4 048/312] ALSA: fm801: explicitly free IRQ line Date: Fri, 8 May 2020 14:30:39 +0200 Message-Id: <20200508123127.933997624@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200508123124.574959822@linuxfoundation.org> References: <20200508123124.574959822@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Andy Shevchenko commit e97e98c63b43040732ad5d1f0b38ad4a8371c73a upstream. Otherwise we will have a warning on ->remove() since device is a PCI one. WARNING: CPU: 4 PID: 1411 at /home/andy/prj/linux/fs/proc/generic.c:575 remove_proc_entry+0x137/0x160() remove_proc_entry: removing non-empty directory 'irq/21', leaking at least 'snd_fm801' Fixes: 5618955c4269 (ALSA: fm801: move to pcim_* and devm_* functions) Signed-off-by: Andy Shevchenko Signed-off-by: Takashi Iwai Signed-off-by: Greg Kroah-Hartman --- sound/pci/fm801.c | 2 ++ 1 file changed, 2 insertions(+) --- a/sound/pci/fm801.c +++ b/sound/pci/fm801.c @@ -1173,6 +1173,8 @@ static int snd_fm801_free(struct fm801 * cmdw |= 0x00c3; fm801_writew(chip, IRQ_MASK, cmdw); + devm_free_irq(&chip->pci->dev, chip->irq, chip); + __end_hw: #ifdef CONFIG_SND_FM801_TEA575X_BOOL if (!(chip->tea575x_tuner & TUNER_DISABLED)) {