From patchwork Mon May 4 17:57:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 226395 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 137FBC3A5A9 for ; Mon, 4 May 2020 18:08:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E4508206B8 for ; Mon, 4 May 2020 18:08:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615684; bh=l+KK+/FOSyJrk8cynsjAzoOlsSuvU8t2q1eoOf25UcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JFgftL3anxJ1x8CXVR3Ukg8mloDH+wgkk2pyiM9qFsBQnurF6J20gLn3or40dc/Wk aGClVuvgSn//fWBbE8iVj4kuDo5eFcIgptXOs4w8GVpd3c2qTekx99XzjlLA3tlxQT qSvTa93aKm2cuUoQmXwyJtXVcaDOVFYENRAdFehI= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731248AbgEDSIC (ORCPT ); Mon, 4 May 2020 14:08:02 -0400 Received: from mail.kernel.org ([198.145.29.99]:39218 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732223AbgEDSIB (ORCPT ); Mon, 4 May 2020 14:08:01 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D2267206B8; Mon, 4 May 2020 18:08:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588615681; bh=l+KK+/FOSyJrk8cynsjAzoOlsSuvU8t2q1eoOf25UcU=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EoJCL+CwkyQYLDjJjb76XinHy7vVRyoWgEjCrvP7ZujzjJRpt4jcZaf5JllDeqte0 G7Me66JCImlMP1j9kEOx0fmekmmy5KI97WxWIdmupF2W6Cur7J1BRxkcZNfPs+oJSl WJe/KlNf/zMAXXR9BTmS3KpmgG95slTvfexFOgMI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Alaa Hleihel , Maor Gottlieb , Leon Romanovsky , Jason Gunthorpe Subject: [PATCH 5.6 45/73] RDMA/mlx4: Initialize ib_spec on the stack Date: Mon, 4 May 2020 19:57:48 +0200 Message-Id: <20200504165508.776092488@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200504165501.781878940@linuxfoundation.org> References: <20200504165501.781878940@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Alaa Hleihel commit c08cfb2d8d78bfe81b37cc6ba84f0875bddd0d5c upstream. Initialize ib_spec on the stack before using it, otherwise we will have garbage values that will break creating default rules with invalid parsing error. Fixes: a37a1a428431 ("IB/mlx4: Add mechanism to support flow steering over IB links") Link: https://lore.kernel.org/r/20200413132235.930642-1-leon@kernel.org Signed-off-by: Alaa Hleihel Reviewed-by: Maor Gottlieb Signed-off-by: Leon Romanovsky Signed-off-by: Jason Gunthorpe Signed-off-by: Greg Kroah-Hartman --- drivers/infiniband/hw/mlx4/main.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) --- a/drivers/infiniband/hw/mlx4/main.c +++ b/drivers/infiniband/hw/mlx4/main.c @@ -1502,8 +1502,9 @@ static int __mlx4_ib_create_default_rule int i; for (i = 0; i < ARRAY_SIZE(pdefault_rules->rules_create_list); i++) { + union ib_flow_spec ib_spec = {}; int ret; - union ib_flow_spec ib_spec; + switch (pdefault_rules->rules_create_list[i]) { case 0: /* no rule */