From patchwork Fri May 1 13:21:02 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 226465 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 67D46C4724C for ; Fri, 1 May 2020 14:01:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 37BEC206D9 for ; Fri, 1 May 2020 14:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588341698; bh=0XSd+zX45sJ8FoxhyxF46ZGpGhtossW6oMCG/N5mrks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=rS520so+xmWsakWIJzD88mFcvj/IUXdcs3G6ziMbuUqyB14FaVWErniOCK0XvgHaC x1q4v7oTTzW1xDbU9f3u7xzrvDwYaSMaWbcqWSv/b1JUg+teoYP9EodhVTGXYPVlSW +xaKp+uVWRxCk41+hbYbRpnWd3D863xFm/Bh5rFY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728851AbgEANZb (ORCPT ); Fri, 1 May 2020 09:25:31 -0400 Received: from mail.kernel.org ([198.145.29.99]:46462 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729031AbgEANZ3 (ORCPT ); Fri, 1 May 2020 09:25:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D85B12173E; Fri, 1 May 2020 13:25:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588339529; bh=0XSd+zX45sJ8FoxhyxF46ZGpGhtossW6oMCG/N5mrks=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hdeIn4CcFWc3+h5jwg2FsJriomh2TTfD2ZAKCWxJWZYmQzFoZPhVRkmC/AzjpZce/ +5U11rpsvekz2cN2Rw23TfzUGpFWGBQORrNq+1fWo9XWAN9fBdq4/AFD2QynElHXuj Png04GoEXHRLdHDPDP380qdVE+Cg/mdCsnhHsYwg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vasily Averin , Andrew Morton , Waiman Long , Davidlohr Bueso , Manfred Spraul , Al Viro , Ingo Molnar , NeilBrown , Peter Oberparleiter , Steven Rostedt , Linus Torvalds , Sasha Levin Subject: [PATCH 4.4 14/70] ipc/util.c: sysvipc_find_ipc() should increase position index Date: Fri, 1 May 2020 15:21:02 +0200 Message-Id: <20200501131517.910739446@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131513.302599262@linuxfoundation.org> References: <20200501131513.302599262@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vasily Averin [ Upstream commit 89163f93c6f969da5811af5377cc10173583123b ] If seq_file .next function does not change position index, read after some lseek can generate unexpected output. https://bugzilla.kernel.org/show_bug.cgi?id=206283 Signed-off-by: Vasily Averin Signed-off-by: Andrew Morton Acked-by: Waiman Long Cc: Davidlohr Bueso Cc: Manfred Spraul Cc: Al Viro Cc: Ingo Molnar Cc: NeilBrown Cc: Peter Oberparleiter Cc: Steven Rostedt Link: http://lkml.kernel.org/r/b7a20945-e315-8bb0-21e6-3875c14a8494@virtuozzo.com Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- ipc/util.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ipc/util.c b/ipc/util.c index 0f401d94b7c65..2724f9071ab39 100644 --- a/ipc/util.c +++ b/ipc/util.c @@ -756,13 +756,13 @@ static struct kern_ipc_perm *sysvipc_find_ipc(struct ipc_ids *ids, loff_t pos, total++; } + *new_pos = pos + 1; if (total >= ids->in_use) return NULL; for (; pos < IPCMNI; pos++) { ipc = idr_find(&ids->ipcs_idr, pos); if (ipc != NULL) { - *new_pos = pos + 1; rcu_read_lock(); ipc_lock_object(ipc); return ipc;