From patchwork Fri May 1 13:22:55 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 226546 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 09406C4724C for ; Fri, 1 May 2020 13:52:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id CCA662051A for ; Fri, 1 May 2020 13:52:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588341175; bh=Q7wr+JoVHPtUK3TZeDjw6cArSL3A4zyLJkI2EYwi8Kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=bRvsIHSFn6E2b/BFfR7iqODziQh3gKFLfjIwrkV2HcQwx4BZ1KC3WOh6mFTaZC9fA qyBlheIB7KBVGfzxqKFlLCOERt8m1Aezs1AdJhyVsu3N56NH6jG9d3oEap07uLQFWk WkQuq89A/WbqNEpJCF5H9k917pRIk+uiBbzbVYpY= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730529AbgEANhN (ORCPT ); Fri, 1 May 2020 09:37:13 -0400 Received: from mail.kernel.org ([198.145.29.99]:36006 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730938AbgEANhK (ORCPT ); Fri, 1 May 2020 09:37:10 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7F28E24966; Fri, 1 May 2020 13:37:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1588340230; bh=Q7wr+JoVHPtUK3TZeDjw6cArSL3A4zyLJkI2EYwi8Kg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=wvqwTNKr7uvZv5TuxZ/xamPG6d668thqblc5ij0ejWAbyZREGMJH9TUdbSbRi2xXG Ki7TOIlEQmMZFjxZmphslsUD6pfS74wjiCyEFmoOF7faFkzvvFMKe9OCQQv+P/9pK0 7q2jimMYO2acmnpsz97qESt9nPNJ7oMbfnnX8Rkk= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Darrick J. Wong" , Brian Foster , Sasha Levin Subject: [PATCH 4.19 30/46] xfs: fix partially uninitialized structure in xfs_reflink_remap_extent Date: Fri, 1 May 2020 15:22:55 +0200 Message-Id: <20200501131509.461589297@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200501131457.023036302@linuxfoundation.org> References: <20200501131457.023036302@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Darrick J. Wong [ Upstream commit c142932c29e533ee892f87b44d8abc5719edceec ] In the reflink extent remap function, it turns out that uirec (the block mapping corresponding only to the part of the passed-in mapping that got unmapped) was not fully initialized. Specifically, br_state was not being copied from the passed-in struct to the uirec. This could lead to unpredictable results such as the reflinked mapping being marked unwritten in the destination file. Signed-off-by: Darrick J. Wong Reviewed-by: Brian Foster Signed-off-by: Sasha Levin --- fs/xfs/xfs_reflink.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/xfs/xfs_reflink.c b/fs/xfs/xfs_reflink.c index f3c393f309e19..6622652a85a80 100644 --- a/fs/xfs/xfs_reflink.c +++ b/fs/xfs/xfs_reflink.c @@ -1058,6 +1058,7 @@ xfs_reflink_remap_extent( uirec.br_startblock = irec->br_startblock + rlen; uirec.br_startoff = irec->br_startoff + rlen; uirec.br_blockcount = unmap_len - rlen; + uirec.br_state = irec->br_state; unmap_len = rlen; /* If this isn't a real mapping, we're done. */