From patchwork Wed Apr 22 09:56:45 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 227059 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1238BC55185 for ; Wed, 22 Apr 2020 10:56:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E69CE20775 for ; Wed, 22 Apr 2020 10:56:33 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587552993; bh=in12tsT4gXL1ga0bTUIzcTFDR64Uyu8m1TorXuPbdVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=hYxmo07nlOhYPrbcOD06Tug6d1J03/V+YNrUcnvFl8+slon9ro2o6HM130qJxBpOU Ivu2aOhsQUwB7jJHle7vgARWaeXg7N88qJ4CWikHaXYODaVgYp+1RgV6V9RoW4ixyF 0Qrba6Gi6qr4/w4IJdeG0ycvUMC7+zfumsgoROcM= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726604AbgDVK43 (ORCPT ); Wed, 22 Apr 2020 06:56:29 -0400 Received: from mail.kernel.org ([198.145.29.99]:58468 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728358AbgDVKG3 (ORCPT ); Wed, 22 Apr 2020 06:06:29 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id A673F20575; Wed, 22 Apr 2020 10:06:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549989; bh=in12tsT4gXL1ga0bTUIzcTFDR64Uyu8m1TorXuPbdVo=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=T6ov6k4fhwB5Td2OAuPCofCz5wbfDDYDwSLSebMX12mB1CEqFWEtubMo7QXDoyH1r gVuBmpZBe2oo37qB10A08JbhVBDd/74pin9hyIsa9hy/0H0e2FA3Kg5rUK4922xdva +0vdUi8lCO26plXIGGeB+5H5lEPb9zC1x/oZfnZg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "Erhard F." , Frank Rowand , Rob Herring Subject: [PATCH 4.9 088/125] of: unittest: kmemleak on changeset destroy Date: Wed, 22 Apr 2020 11:56:45 +0200 Message-Id: <20200422095047.225506345@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095032.909124119@linuxfoundation.org> References: <20200422095032.909124119@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Frank Rowand commit b3fb36ed694b05738d45218ea72cf7feb10ce2b1 upstream. kmemleak reports several memory leaks from devicetree unittest. This is the fix for problem 1 of 5. of_unittest_changeset() reaches deeply into the dynamic devicetree functions. Several nodes were left with an elevated reference count and thus were not properly cleaned up. Fix the reference counts so that the memory will be freed. Fixes: 201c910bd689 ("of: Transactional DT support.") Reported-by: Erhard F. Signed-off-by: Frank Rowand Signed-off-by: Rob Herring Signed-off-by: Greg Kroah-Hartman --- drivers/of/unittest.c | 4 ++++ 1 file changed, 4 insertions(+) --- a/drivers/of/unittest.c +++ b/drivers/of/unittest.c @@ -539,6 +539,10 @@ static void __init of_unittest_changeset unittest(!of_changeset_revert(&chgset), "revert failed\n"); of_changeset_destroy(&chgset); + + of_node_put(n1); + of_node_put(n2); + of_node_put(n21); #endif }