From patchwork Wed Apr 22 09:55:48 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 227012 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5148CC55189 for ; Wed, 22 Apr 2020 11:02:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 261D02076E for ; Wed, 22 Apr 2020 11:02:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587553348; bh=Wwmox0R4RoMH1wIvUK45KwsgmKAYgn9Af7TOQuHnS1Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=fY1ACopFM8ZP9P4W1pAhIJ8+84JX5Pc49EGo21K3RQdM2G8QFB05iLVG7GqYNl/Z8 GcEQ5IZcbYjHl4NQFEn0Zkucil/kEyEFQZhqAMp84ByaOZl/HEcf1HODDTGtkBTk/9 SQEe9D3i06+KtV/DVgerrwjaeL3Ov1ay9D8UAA14= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732348AbgDVLC0 (ORCPT ); Wed, 22 Apr 2020 07:02:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:47886 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726654AbgDVKAi (ORCPT ); Wed, 22 Apr 2020 06:00:38 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 1E41E20735; Wed, 22 Apr 2020 10:00:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1587549638; bh=Wwmox0R4RoMH1wIvUK45KwsgmKAYgn9Af7TOQuHnS1Q=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=z4ZS3K2J6IcQyKsKJY1cOBU+MiQ6nxoTEHBlMuuoQNGpG4MNOnl8ar6p/g4VwgRyd siTkRE2a2bmAwWIjFrZKdqgpInneA+5J3I1tJh+KVbk2iqlbbx6TK9MqfzI9MhDZrK +H6INElBDIsQHqfrs+SkZoU7xS7+0MNuSnVR8oRw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sriharsha Allenki , Peter Chen Subject: [PATCH 4.4 018/100] usb: gadget: f_fs: Fix use after free issue as part of queue failure Date: Wed, 22 Apr 2020 11:55:48 +0200 Message-Id: <20200422095026.140789186@linuxfoundation.org> X-Mailer: git-send-email 2.26.2 In-Reply-To: <20200422095022.476101261@linuxfoundation.org> References: <20200422095022.476101261@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sriharsha Allenki commit f63ec55ff904b2f2e126884fcad93175f16ab4bb upstream. In AIO case, the request is freed up if ep_queue fails. However, io_data->req still has the reference to this freed request. In the case of this failure if there is aio_cancel call on this io_data it will lead to an invalid dequeue operation and a potential use after free issue. Fix this by setting the io_data->req to NULL when the request is freed as part of queue failure. Fixes: 2e4c7553cd6f ("usb: gadget: f_fs: add aio support") Signed-off-by: Sriharsha Allenki CC: stable Reviewed-by: Peter Chen Link: https://lore.kernel.org/r/20200326115620.12571-1-sallenki@codeaurora.org Signed-off-by: Greg Kroah-Hartman --- drivers/usb/gadget/function/f_fs.c | 1 + 1 file changed, 1 insertion(+) --- a/drivers/usb/gadget/function/f_fs.c +++ b/drivers/usb/gadget/function/f_fs.c @@ -812,6 +812,7 @@ static ssize_t ffs_epfile_io(struct file ret = usb_ep_queue(ep->ep, req, GFP_ATOMIC); if (unlikely(ret)) { + io_data->req = NULL; usb_ep_free_request(ep->ep, req); goto error_lock; }