From patchwork Wed Apr 1 16:16:52 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: "gregkh@linuxfoundation.org" X-Patchwork-Id: 228296 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id AAD24C2D0F0 for ; Wed, 1 Apr 2020 16:55:27 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8024220714 for ; Wed, 1 Apr 2020 16:55:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585760127; bh=AY71obNf1Q6UB9Va0NbDL8+4U8PXAhRAQSmgjRWd5Dg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=LI1iPemTR+MLKB2/g0fRzWPJ2V+EKon340q/MjKtjBCNEu3aXHoqBDrpSidOHyAyZ n7qxUIpjvXGuvo9iCtidWOPDHr4UfiZwxpFOoeMnM6BAomEDNeVkT7ji54nFxrnyis jCgVy2R/ywDyzWGzFrvX+2MJ2ThZmAA25xK/qdmk= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1733000AbgDAQzW (ORCPT ); Wed, 1 Apr 2020 12:55:22 -0400 Received: from mail.kernel.org ([198.145.29.99]:48190 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387521AbgDAQYb (ORCPT ); Wed, 1 Apr 2020 12:24:31 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41570212CC; Wed, 1 Apr 2020 16:24:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1585758270; bh=AY71obNf1Q6UB9Va0NbDL8+4U8PXAhRAQSmgjRWd5Dg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=aSZyQzH2loQ9Ecdee/lzCTs55bBbameSxzAJSU9Yms9FEPS2u8Wiq3vUmy1erMw7p 40SfmJbm0RB7FosB3FkrSpnu5X0k8HqVHGUOZPpd2EWq3UUmOTqthu9pqQN69zt9PX 3QQvelso1s53kqvkE5Qb88B/tCmlqcnsaizMTppI= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Dajun Jin , Andrew Lunn , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 036/116] drivers/of/of_mdio.c:fix of_mdiobus_register() Date: Wed, 1 Apr 2020 18:16:52 +0200 Message-Id: <20200401161547.030345160@linuxfoundation.org> X-Mailer: git-send-email 2.26.0 In-Reply-To: <20200401161542.669484650@linuxfoundation.org> References: <20200401161542.669484650@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Dajun Jin [ Upstream commit 209c65b61d94344522c41a83cd6ce51aac5fd0a4 ] When registers a phy_device successful, should terminate the loop or the phy_device would be registered in other addr. If there are multiple PHYs without reg properties, it will go wrong. Signed-off-by: Dajun Jin Reviewed-by: Andrew Lunn Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/of/of_mdio.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/of/of_mdio.c b/drivers/of/of_mdio.c index 7d2bc22680d90..af7572fe090fd 100644 --- a/drivers/of/of_mdio.c +++ b/drivers/of/of_mdio.c @@ -270,6 +270,7 @@ int of_mdiobus_register(struct mii_bus *mdio, struct device_node *np) rc = of_mdiobus_register_phy(mdio, child, addr); if (rc && rc != -ENODEV) goto unregister; + break; } } }