From patchwork Thu Mar 19 12:59:28 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 228936 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 382C9C43332 for ; Thu, 19 Mar 2020 13:38:44 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 073C520789 for ; Thu, 19 Mar 2020 13:38:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584625124; bh=5vB8mUdyw2isuB6lmMYIy2+5uMEcnHqGLYk6HsSd1Ek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=1vHD3XEWm7bRBebSuYYATfEwcgaw9VzaccPGBBB4TROV83FBvCMg+z/dP9YeJgHNO 47z+M35JRXIhKM3uTf4HaOy+aLPXQ0cbYcmm/yRrpmk9s5VwzGgq5/QN0KeFQdrwsY CaZ2C1c49PB30GIH2xImgbQkBOTeEtZkjZQz/5so= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727500AbgCSNFw (ORCPT ); Thu, 19 Mar 2020 09:05:52 -0400 Received: from mail.kernel.org ([198.145.29.99]:48690 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727488AbgCSNFt (ORCPT ); Thu, 19 Mar 2020 09:05:49 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 5062620740; Thu, 19 Mar 2020 13:05:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584623148; bh=5vB8mUdyw2isuB6lmMYIy2+5uMEcnHqGLYk6HsSd1Ek=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=rjwpMbqV56P2xpmpxbP19bZ7BdAcT+JQhUcqfWq24xpMo4Oae+UrcVBh2ixSuKkVO GhNRQYYhYz+fcgk1jfW0ANmeJRlp6z52rcdufa5qdjtmEyjTfdBAD/fhYQcTGWyRXA tyd03reJguYa3wOixWQED7pOcao6Bi8bSvyAyfrs= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Al Viro , stable@kernel.org Subject: [PATCH 4.4 24/93] gfs2_atomic_open(): fix O_EXCL|O_CREAT handling on cold dcache Date: Thu, 19 Mar 2020 13:59:28 +0100 Message-Id: <20200319123932.723472468@linuxfoundation.org> X-Mailer: git-send-email 2.25.2 In-Reply-To: <20200319123924.795019515@linuxfoundation.org> References: <20200319123924.795019515@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Al Viro commit 21039132650281de06a169cbe8a0f7e5c578fd8b upstream. with the way fs/namei.c:do_last() had been done, ->atomic_open() instances needed to recognize the case when existing file got found with O_EXCL|O_CREAT, either by falling back to finish_no_open() or failing themselves. gfs2 one didn't. Fixes: 6d4ade986f9c (GFS2: Add atomic_open support) Cc: stable@kernel.org # v3.11 Signed-off-by: Al Viro Signed-off-by: Greg Kroah-Hartman --- fs/gfs2/inode.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/fs/gfs2/inode.c +++ b/fs/gfs2/inode.c @@ -1245,7 +1245,7 @@ static int gfs2_atomic_open(struct inode if (!(*opened & FILE_OPENED)) return finish_no_open(file, d); dput(d); - return 0; + return excl && (flags & O_CREAT) ? -EEXIST : 0; } BUG_ON(d != NULL);