From patchwork Tue Mar 17 10:54:17 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 229301 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D908BC18E5B for ; Tue, 17 Mar 2020 11:08:52 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id AB491205ED for ; Tue, 17 Mar 2020 11:08:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443332; bh=moDZeG3Bq5WsFe3GGa6LbpjpT5cKm5f2KisslQaJFbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=P04Ac7KI8kFY6vyIKq4ERsxupFtkuc8sy9U/ahIIHBzttFahUwKPLTWjG+fUczgf8 Au9n5odg/GoGe252pbpCJRdhWeYBIdTByovxRju2vistJWmk4d+q3vUAr/z5n6mgEr S+MpY32DTLLnaXDtnle11Gy1mp5wajLW9o3gH5Xc= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728891AbgCQLIv (ORCPT ); Tue, 17 Mar 2020 07:08:51 -0400 Received: from mail.kernel.org ([198.145.29.99]:50858 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728890AbgCQLIu (ORCPT ); Tue, 17 Mar 2020 07:08:50 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id D8F2520658; Tue, 17 Mar 2020 11:08:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443330; bh=moDZeG3Bq5WsFe3GGa6LbpjpT5cKm5f2KisslQaJFbI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tt3l+w7YgWrejXQmlB8Co6KfaXn3G06irmLhiaQV7CCGK/lCq8m5Fwy5FZV/2TWUq qzjQKws59K8uiKu0WKUoviPIzaWymk5+anw7SL9bM8Gn1GIOXFSayPcIMwUjJiimu5 LulTBBW6ZHSUwFvBg/Ne24/8v6S+5CVR+Wkyheu8= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jakub Kicinski , Jiri Pirko , "David S. Miller" Subject: [PATCH 5.5 047/151] devlink: validate length of region addr/len Date: Tue, 17 Mar 2020 11:54:17 +0100 Message-Id: <20200317103329.941073777@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103326.593639086@linuxfoundation.org> References: <20200317103326.593639086@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Jakub Kicinski [ Upstream commit ff3b63b8c299b73ac599b120653b47e275407656 ] DEVLINK_ATTR_REGION_CHUNK_ADDR and DEVLINK_ATTR_REGION_CHUNK_LEN lack entries in the netlink policy. Corresponding nla_get_u64()s may read beyond the end of the message. Fixes: 4e54795a27f5 ("devlink: Add support for region snapshot read command") Signed-off-by: Jakub Kicinski Reviewed-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/core/devlink.c | 2 ++ 1 file changed, 2 insertions(+) --- a/net/core/devlink.c +++ b/net/core/devlink.c @@ -5924,6 +5924,8 @@ static const struct nla_policy devlink_n [DEVLINK_ATTR_PARAM_VALUE_CMODE] = { .type = NLA_U8 }, [DEVLINK_ATTR_REGION_NAME] = { .type = NLA_NUL_STRING }, [DEVLINK_ATTR_REGION_SNAPSHOT_ID] = { .type = NLA_U32 }, + [DEVLINK_ATTR_REGION_CHUNK_ADDR] = { .type = NLA_U64 }, + [DEVLINK_ATTR_REGION_CHUNK_LEN] = { .type = NLA_U64 }, [DEVLINK_ATTR_HEALTH_REPORTER_NAME] = { .type = NLA_NUL_STRING }, [DEVLINK_ATTR_HEALTH_REPORTER_GRACEFUL_PERIOD] = { .type = NLA_U64 }, [DEVLINK_ATTR_HEALTH_REPORTER_AUTO_RECOVER] = { .type = NLA_U8 },