From patchwork Tue Mar 17 10:55:50 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 229231 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6B8C4C18E5B for ; Tue, 17 Mar 2020 11:18:38 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 38D83206EC for ; Tue, 17 Mar 2020 11:18:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443918; bh=PqdHORoBu8IQMRinRk+mOGPyeYvUa3JSAPiknsC39X0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=e+Oi4n+TAsKoNe3kwvARW5PORot5RvwQoXNipemICMc7Ei9C+o/wlgJX8XpRTGy81 Yf4a//JTsY6NsqUEXAztzY/mD7V4N//Z37rncb4LjgsNR3kEi1Z2CxK0zgHQILvXLR nLFHKfRxPF+l8TxsbWWxtY3u0uaDge+BjUVMW0bU= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728537AbgCQLGU (ORCPT ); Tue, 17 Mar 2020 07:06:20 -0400 Received: from mail.kernel.org ([198.145.29.99]:47350 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727620AbgCQLGR (ORCPT ); Tue, 17 Mar 2020 07:06:17 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 41A8320658; Tue, 17 Mar 2020 11:06:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584443176; bh=PqdHORoBu8IQMRinRk+mOGPyeYvUa3JSAPiknsC39X0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=hwZogs9NbZ64arm9xoJW3HgfzLCBYKLWfaSEuitNVZl9dOsvR/K+xjjS/0CIf7Mdr b+K+kc0Hsu+1ZMayox5Tfle2YVulR8JZMwcyErrBLZ7+w9gkoInJ2hd7IdoSkv1YiO Ipl3pnfZSMjXEl/6zCMo/utyMmGeovLQopdRl66s= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, syzbot+b297c6825752e7a07272@syzkaller.appspotmail.com, Karsten Graul , Ursula Braun , Leon Romanovsky , "David S. Miller" Subject: [PATCH 5.4 123/123] net/smc: cancel event worker during device removal Date: Tue, 17 Mar 2020 11:55:50 +0100 Message-Id: <20200317103319.793659199@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103307.343627747@linuxfoundation.org> References: <20200317103307.343627747@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Karsten Graul commit ece0d7bd74615773268475b6b64d6f1ebbd4b4c6 upstream. During IB device removal, cancel the event worker before the device structure is freed. Fixes: a4cf0443c414 ("smc: introduce SMC as an IB-client") Reported-by: syzbot+b297c6825752e7a07272@syzkaller.appspotmail.com Signed-off-by: Karsten Graul Reviewed-by: Ursula Braun Reviewed-by: Leon Romanovsky Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/smc/smc_ib.c | 1 + 1 file changed, 1 insertion(+) --- a/net/smc/smc_ib.c +++ b/net/smc/smc_ib.c @@ -568,6 +568,7 @@ static void smc_ib_remove_dev(struct ib_ spin_unlock(&smc_ib_devices.lock); smc_ib_cleanup_per_ibdev(smcibdev); ib_unregister_event_handler(&smcibdev->event_handler); + cancel_work_sync(&smcibdev->port_event_work); kfree(smcibdev); }