From patchwork Tue Mar 17 10:55:37 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 229344 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B65F8C2BB1D for ; Tue, 17 Mar 2020 11:00:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 85C5C2076A for ; Tue, 17 Mar 2020 11:00:14 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442814; bh=dhGUR4xatn233XksUDPF0ILpwQzNjiz/U8o9OsPwpEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=GCuGjMU6SWtEBC9fOfTy1Vq29j7pSYMQaaXKdXnLeEWD/MdaIEqsKAOWrApqaIdIU cWyTzADiuf4xQoscSy7X1F/4B8zfW0n0el/1EZjUMBlrDqJv+COw4MaEQ9hQk5ynda N2+1R9VBwEdnt+68l58p+SLNqC/nUagQunHN120U= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727559AbgCQLAI (ORCPT ); Tue, 17 Mar 2020 07:00:08 -0400 Received: from mail.kernel.org ([198.145.29.99]:39040 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727556AbgCQLAI (ORCPT ); Tue, 17 Mar 2020 07:00:08 -0400 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 4B8DD20736; Tue, 17 Mar 2020 11:00:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1584442807; bh=dhGUR4xatn233XksUDPF0ILpwQzNjiz/U8o9OsPwpEc=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=tDmfCxg2SqQFa8ijfjJUoEOjIHL5ICzmkJ4nrtiAPWk6jwUSqBcNK7gf8bsjkeCIt nmLVcAXqqDGZOltnT6Z+q/Jdr9zIK69Qd3Y2ffB/zcwiiX6QJIEJ5uOKb1SD3lFVjK ye3RBajTNjFAc4j2NorHx6OVPiAnuurrkwsbgrOo= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Vladis Dronov , Ard Biesheuvel , Ingo Molnar Subject: [PATCH 4.19 88/89] efi: Add a sanity check to efivar_store_raw() Date: Tue, 17 Mar 2020 11:55:37 +0100 Message-Id: <20200317103310.194798201@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317103259.744774526@linuxfoundation.org> References: <20200317103259.744774526@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Vladis Dronov commit d6c066fda90d578aacdf19771a027ed484a79825 upstream. Add a sanity check to efivar_store_raw() the same way efivar_{attr,size,data}_read() and efivar_show_raw() have it. Signed-off-by: Vladis Dronov Signed-off-by: Ard Biesheuvel Signed-off-by: Ingo Molnar Cc: Link: https://lore.kernel.org/r/20200305084041.24053-3-vdronov@redhat.com Link: https://lore.kernel.org/r/20200308080859.21568-25-ardb@kernel.org Signed-off-by: Greg Kroah-Hartman --- drivers/firmware/efi/efivars.c | 3 +++ 1 file changed, 3 insertions(+) --- a/drivers/firmware/efi/efivars.c +++ b/drivers/firmware/efi/efivars.c @@ -272,6 +272,9 @@ efivar_store_raw(struct efivar_entry *en u8 *data; int err; + if (!entry || !buf) + return -EINVAL; + if (is_compat()) { struct compat_efi_variable *compat;