From patchwork Fri Feb 21 07:35:31 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 231042 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C722C35641 for ; Fri, 21 Feb 2020 07:44:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 450B6207FD for ; Fri, 21 Feb 2020 07:44:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271093; bh=nKJjF866yjwJPSLo14ekLgStyMcGGRJrLmEcN+E0vcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=YXhJQ0FFhJHGvKTxKx8ehp/2ZExEncwkYtPUQAd2h0x7bAusAMdmXdjz1dQXbCYiK PHF6NI4U561+21wu2LSk0mxve+xAoIXMvOb9dIE/PuybMLzfsxlOTGqCOOutOTntCl pn1n2G70f0vJsWnRtDAZju0jLVWCxUDTrPM+G3c8= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728158AbgBUHor (ORCPT ); Fri, 21 Feb 2020 02:44:47 -0500 Received: from mail.kernel.org ([198.145.29.99]:39680 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728148AbgBUHor (ORCPT ); Fri, 21 Feb 2020 02:44:47 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 272DC20801; Fri, 21 Feb 2020 07:44:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1582271086; bh=nKJjF866yjwJPSLo14ekLgStyMcGGRJrLmEcN+E0vcA=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=IOFnKkxDRfRgOhUTz5RBCq4QEHoTbMywwxQk1dUR1qQ9xvRYWmTkqg2afGIq4K5Fn tySLzoqL5A7F5sHEjEQJClR7J9JAwWqDAEJ5YzJ/TMdZ6Cmq6Ki8uTb1LEL9lQmGTt FlHumCfsQVUpbnrz/4kYLVby7upNyXW36iJuUm2Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Davide Caratti , Jiri Pirko , "David S. Miller" Subject: [PATCH 5.5 006/399] net/sched: flower: add missing validation of TCA_FLOWER_FLAGS Date: Fri, 21 Feb 2020 08:35:31 +0100 Message-Id: <20200221072402.933005748@linuxfoundation.org> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200221072402.315346745@linuxfoundation.org> References: <20200221072402.315346745@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Davide Caratti [ Upstream commit e2debf0852c4d66ba1a8bde12869b196094c70a7 ] unlike other classifiers that can be offloaded (i.e. users can set flags like 'skip_hw' and 'skip_sw'), 'cls_flower' doesn't validate the size of netlink attribute 'TCA_FLOWER_FLAGS' provided by user: add a proper entry to fl_policy. Fixes: 5b33f48842fa ("net/flower: Introduce hardware offload support") Signed-off-by: Davide Caratti Acked-by: Jiri Pirko Signed-off-by: David S. Miller Signed-off-by: Greg Kroah-Hartman --- net/sched/cls_flower.c | 1 + 1 file changed, 1 insertion(+) --- a/net/sched/cls_flower.c +++ b/net/sched/cls_flower.c @@ -691,6 +691,7 @@ static const struct nla_policy fl_policy .len = 128 / BITS_PER_BYTE }, [TCA_FLOWER_KEY_CT_LABELS_MASK] = { .type = NLA_BINARY, .len = 128 / BITS_PER_BYTE }, + [TCA_FLOWER_FLAGS] = { .type = NLA_U32 }, }; static const struct nla_policy