From patchwork Thu Feb 13 15:19:40 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 231208 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66F27C3B189 for ; Thu, 13 Feb 2020 16:10:22 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 23E17206ED for ; Thu, 13 Feb 2020 16:10:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581610222; bh=vF4Tl7FSUcGUORXXCvptmOuZZk3w99WSLJoEbil353U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=RsgYVEqscQ4kzy+FG1HwhL71aAyAYK76Gr/mMF3RiPocIwF6YVP0Oar3FA3wYRmaL c8QkIVYmrCiUc0ofXda/X2Z6nHWu6bPeco86zEY+Qfp7EeD1t44F/mKTykQORubr8V yVRGVWnF974wJr/rn7MTc0hSJokV7m8X8PptR+co= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728022AbgBMPWi (ORCPT ); Thu, 13 Feb 2020 10:22:38 -0500 Received: from mail.kernel.org ([198.145.29.99]:60336 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728010AbgBMPWi (ORCPT ); Thu, 13 Feb 2020 10:22:38 -0500 Received: from localhost (unknown [104.132.1.104]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 7A9122469A; Thu, 13 Feb 2020 15:22:36 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1581607356; bh=vF4Tl7FSUcGUORXXCvptmOuZZk3w99WSLJoEbil353U=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=WzgZoMmb+N1wLN1PBMnVRJ7dAXFuyEHCDBhkFQMo7beUJB4bphBvyFO4OE7u5Iid4 ux+DZjyKmnrdfl/8fcBQTIkxJB48CroTff42fngz6VlfuAK2vd3d70lhisbS62Yjol GGNw43OOjWE7PSMHBagZm5+5HLUUiWWPWFyAtvZw= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Sven Van Asbroeck , Sebastian Reichel Subject: [PATCH 4.4 23/91] power: supply: ltc2941-battery-gauge: fix use-after-free Date: Thu, 13 Feb 2020 07:19:40 -0800 Message-Id: <20200213151830.591680561@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200213151821.384445454@linuxfoundation.org> References: <20200213151821.384445454@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Sven Van Asbroeck commit a60ec78d306c6548d4adbc7918b587a723c555cc upstream. This driver's remove path calls cancel_delayed_work(). However, that function does not wait until the work function finishes. This could mean that the work function is still running after the driver's remove function has finished, which would result in a use-after-free. Fix by calling cancel_delayed_work_sync(), which ensures that that the work is properly cancelled, no longer running, and unable to re-schedule itself. This issue was detected with the help of Coccinelle. Cc: stable Signed-off-by: Sven Van Asbroeck Signed-off-by: Sebastian Reichel Signed-off-by: Greg Kroah-Hartman --- drivers/power/ltc2941-battery-gauge.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/power/ltc2941-battery-gauge.c +++ b/drivers/power/ltc2941-battery-gauge.c @@ -364,7 +364,7 @@ static int ltc294x_i2c_remove(struct i2c { struct ltc294x_info *info = i2c_get_clientdata(client); - cancel_delayed_work(&info->work); + cancel_delayed_work_sync(&info->work); power_supply_unregister(info->supply); return 0; }