From patchwork Mon Feb 3 16:19:01 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 232096 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_BLOCKED, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4FBAC35247 for ; Mon, 3 Feb 2020 16:47:15 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BB6702051A for ; Mon, 3 Feb 2020 16:47:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580748435; bh=Mk4vzYviUrOYODydEGb0g0Jx38FB2OMBIl3s58qcUGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=urkhgfSVUAzWU0O9bTEsXrqzmhExI9L103lxEWvVD3/K/eY/hKinfHhzYzVY1gkEB cU7XgPoiJBj6T4lYekKprlEINEEBwWduoT7vJ7Ic5Ua78mawhLANIgR2AyCeHm3WJP NgwcffEk3CyfPnVBkhgEvTUkdMNQmvrlr8/6Uwvo= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729511AbgBCQrK (ORCPT ); Mon, 3 Feb 2020 11:47:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:39340 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728089AbgBCQ1z (ORCPT ); Mon, 3 Feb 2020 11:27:55 -0500 Received: from localhost (unknown [104.132.45.99]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 8E3E72080C; Mon, 3 Feb 2020 16:27:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580747275; bh=Mk4vzYviUrOYODydEGb0g0Jx38FB2OMBIl3s58qcUGM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=f4P+bNYSHiXoiBk7r4lsRzHeLseXbt9/dLzcZaPTuDnlL+h58Y79wPR5V9nGesjgl 0+Klg7bgiglQdQCZz4jG0sDObMGiHR+Sz7GXR/zHUF+q84Yes3CWC1+xHTJYS53LNE oodVh1EmX8zti4RxawWd7VTHoMFt6uSQZ/SolxVg= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Jes Sorensen , Johan Hovold , Kalle Valo Subject: [PATCH 4.14 16/89] rtl8xxxu: fix interface sanity check Date: Mon, 3 Feb 2020 16:19:01 +0000 Message-Id: <20200203161919.067020127@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200203161916.847439465@linuxfoundation.org> References: <20200203161916.847439465@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Johan Hovold commit 39a4281c312f2d226c710bc656ce380c621a2b16 upstream. Make sure to use the current alternate setting when verifying the interface descriptors to avoid binding to an invalid interface. Failing to do so could cause the driver to misbehave or trigger a WARN() in usb_submit_urb() that kernels with panic_on_warn set would choke on. Fixes: 26f1fad29ad9 ("New driver: rtl8xxxu (mac80211)") Cc: stable # 4.4 Cc: Jes Sorensen Signed-off-by: Johan Hovold Signed-off-by: Kalle Valo Signed-off-by: Greg Kroah-Hartman --- drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- a/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c +++ b/drivers/net/wireless/realtek/rtl8xxxu/rtl8xxxu_core.c @@ -5921,7 +5921,7 @@ static int rtl8xxxu_parse_usb(struct rtl u8 dir, xtype, num; int ret = 0; - host_interface = &interface->altsetting[0]; + host_interface = interface->cur_altsetting; interface_desc = &host_interface->desc; endpoints = interface_desc->bNumEndpoints;