From patchwork Tue Jan 28 14:05:34 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg Kroah-Hartman X-Patchwork-Id: 232490 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.3 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY, SPF_HELO_NONE, SPF_PASS, URIBL_DBL_ABUSE_MALW, USER_AGENT_GIT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A138EC2D0DB for ; Tue, 28 Jan 2020 14:42:21 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 790BE24691 for ; Tue, 28 Jan 2020 14:42:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580222541; bh=lj+GWmybPZjmwTYNtb7dYZcWyhiodEmLuVMxyv3X4MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=xbWvIR/XwYrr7P346tGCZO0f545C40OaJTRkQJIZQgfPbarqKoW8heNrfTcxuS6uh 626bHs0o4J/CZhQ+NrVeEoIDjSi6ibq8v1aEVNfeMEDOiqVVsE/eiy5DgW+mVT46T6 tP6+IW+xOZisj6KUl6XhB7D/3CG2WwIe+bmvLozs= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729662AbgA1ONU (ORCPT ); Tue, 28 Jan 2020 09:13:20 -0500 Received: from mail.kernel.org ([198.145.29.99]:34938 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729214AbgA1ONT (ORCPT ); Tue, 28 Jan 2020 09:13:19 -0500 Received: from localhost (83-86-89-107.cable.dynamic.v4.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 61FC820678; Tue, 28 Jan 2020 14:13:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1580220798; bh=lj+GWmybPZjmwTYNtb7dYZcWyhiodEmLuVMxyv3X4MQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=l0irqLSgpgMdFVE+fQhEq+FeT835Pp/jcsOYN4h0N1NAMrEPVHAvxW40xzhGrCoLj cmpRNHzwnUITJPtljVMcxQQGn3G5UUePJ2yjrwZuIOTRKw79WEn1gWePlSF4nUAfoU 8Osn3EfHeGV2pJwnM5z7qHyR62mGo+bJbouW/64A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Thomas Gleixner , "Peter Zijlstra (Intel)" , Sasha Levin Subject: [PATCH 4.4 115/183] x86/kgbd: Use NMI_VECTOR not APIC_DM_NMI Date: Tue, 28 Jan 2020 15:05:34 +0100 Message-Id: <20200128135841.410496373@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200128135829.486060649@linuxfoundation.org> References: <20200128135829.486060649@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Thomas Gleixner [ Upstream commit 2591bc4e8d70b4e1330d327fb7e3921f4e070a51 ] apic->send_IPI_allbutself() takes a vector number as argument. APIC_DM_NMI is clearly not a vector number. It's defined to 0x400 which is outside the vector space. Use NMI_VECTOR instead as that's what it is intended to be. Fixes: 82da3ff89dc2 ("x86: kgdb support") Signed-off-by: Thomas Gleixner Acked-by: Peter Zijlstra (Intel) Link: https://lkml.kernel.org/r/20190722105218.855189979@linutronix.de Signed-off-by: Sasha Levin --- arch/x86/kernel/kgdb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/x86/kernel/kgdb.c b/arch/x86/kernel/kgdb.c index 44256a62702b2..4a08fda2b06f0 100644 --- a/arch/x86/kernel/kgdb.c +++ b/arch/x86/kernel/kgdb.c @@ -437,7 +437,7 @@ static void kgdb_disable_hw_debug(struct pt_regs *regs) */ void kgdb_roundup_cpus(unsigned long flags) { - apic->send_IPI_allbutself(APIC_DM_NMI); + apic->send_IPI_allbutself(NMI_VECTOR); } #endif