From patchwork Fri Jan 24 09:30:26 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Greg KH X-Patchwork-Id: 232939 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.8 required=3.0 tests=DKIMWL_WL_HIGH, DKIM_SIGNED, DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH, MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 46267C35242 for ; Fri, 24 Jan 2020 11:25:12 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1976120704 for ; Fri, 24 Jan 2020 11:25:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865112; bh=347xYjqGo2/cdyy/6HnlMu+UtDDr7Ln9gkQu+a6DbQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:List-ID:From; b=JPOMphjCPuLRIVpbL7D0baRM4hoQBq2CZjb9b6ksIaneXyonp+J2QPJB4M+QoKo3K sP/KW4m+HteIL4MMDhI/ki5g7dOsx9+k/Yl1A/jRowDXieSpajaH+ngTSVKfXKmjJG eNchIeJfwp8rFqtuwtzsQh2dORxxMaVj1ydizVPQ= Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2403852AbgAXLZK (ORCPT ); Fri, 24 Jan 2020 06:25:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:39112 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2403849AbgAXLZJ (ORCPT ); Fri, 24 Jan 2020 06:25:09 -0500 Received: from localhost (ip-213-127-102-57.ip.prioritytelecom.net [213.127.102.57]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id C2F45206D4; Fri, 24 Jan 2020 11:25:08 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1579865109; bh=347xYjqGo2/cdyy/6HnlMu+UtDDr7Ln9gkQu+a6DbQk=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NrDrbwNL06bWa8nPYjBQdKGeY9xMw0JKehTv1Wb5FeaqeTxNjuSGojmpTm+bM+FM9 qm5yG6GUooutIjKhhJPNHl8OnJqn0sTCwnY9YU3JffDdIFk++H3r2R2i8hG7k2xlGi Dws1WcFX3h6WAirdq5O5dLlPoMWzAAqj57pCAYiA= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Michael Chan , "David S. Miller" , Sasha Levin Subject: [PATCH 4.19 456/639] bnxt_en: Suppress error messages when querying DSCP DCB capabilities. Date: Fri, 24 Jan 2020 10:30:26 +0100 Message-Id: <20200124093144.302099247@linuxfoundation.org> X-Mailer: git-send-email 2.25.0 In-Reply-To: <20200124093047.008739095@linuxfoundation.org> References: <20200124093047.008739095@linuxfoundation.org> User-Agent: quilt/0.66 MIME-Version: 1.0 Sender: stable-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: stable@vger.kernel.org From: Michael Chan [ Upstream commit 4ca5fa39e1aea2f85eb9c4257075c4077c6531da ] Some firmware versions do not support this so use the silent variant to send the message to firmware to suppress the harmless error. This error message is unnecessarily alarming the user. Fixes: afdc8a84844a ("bnxt_en: Add DCBNL DSCP application protocol support.") Signed-off-by: Michael Chan Signed-off-by: David S. Miller Signed-off-by: Sasha Levin --- drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c index a85d2be986af4..0e4e0b47f5d85 100644 --- a/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c +++ b/drivers/net/ethernet/broadcom/bnxt/bnxt_dcb.c @@ -396,7 +396,7 @@ static int bnxt_hwrm_queue_dscp_qcaps(struct bnxt *bp) bnxt_hwrm_cmd_hdr_init(bp, &req, HWRM_QUEUE_DSCP_QCAPS, -1, -1); mutex_lock(&bp->hwrm_cmd_lock); - rc = _hwrm_send_message(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); + rc = _hwrm_send_message_silent(bp, &req, sizeof(req), HWRM_CMD_TIMEOUT); if (!rc) { bp->max_dscp_value = (1 << resp->num_dscp_bits) - 1; if (bp->max_dscp_value < 0x3f)